Bug 42567 - Fix Build after GNOMENG mass commit
Summary: Fix Build after GNOMENG mass commit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-09 00:30 UTC by Tilman Linneweh
Modified: 2002-09-09 02:17 UTC (History)
1 user (show)

See Also:


Attachments
xhippo.diff (661 bytes, patch)
2002-09-09 00:30 UTC, Tilman Linneweh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tilman Linneweh 2002-09-09 00:30:02 UTC
	Noticed by bento: 	gtk is needed in every case
	If WITH_GNOME, configure looks for gnome-config -> Added gnomelibs to i
	USE_GNOME
Comment 1 Alan Eldridge 2002-09-09 00:35:04 UTC
On Mon, Sep 09, 2002 at 01:26:47AM +0200, Tilman Linneweh wrote:
>diff -u -r1.21 Makefile
>--- Makefile	31 Aug 2002 00:13:22 -0000	1.21
>+++ Makefile	8 Sep 2002 23:22:52 -0000
>@@ -17,6 +17,7 @@
> 
> USE_XLIB=	yes
> USE_GNOMENG=	yes
>+USE_GNOME=	gtk12

shouldn't that be += ???
-- 
Alan Eldridge
Unix/C(++) IT Pro, 20 yrs, seeking new employment.
(http://wwweasel.geeksrus.net/~alane/resume.txt)
KDE, KDE-FreeBSD Teams (http://www.kde.org, http://freebsd.kde.org/)
Comment 2 Tilman Linneweh 2002-09-09 00:40:05 UTC
Hello Alan,

* Alan E <alane@geeksrus.net> [Sun, 8 Sep 2002 19:35:04 -0400]:

> On Mon, Sep 09, 2002 at 01:26:47AM +0200, Tilman Linneweh wrote:
> >diff -u -r1.21 Makefile
> >--- Makefile	31 Aug 2002 00:13:22 -0000	1.21
> >+++ Makefile	8 Sep 2002 23:22:52 -0000
> >@@ -17,6 +17,7 @@
> > 
> > USE_XLIB=	yes
> > USE_GNOMENG=	yes
> >+USE_GNOME=	gtk12
> 
> shouldn't that be += ???

I don't think so..there isn't a possibility that anything is added to USE_GNOME
before this (slaveports or something like that). Or am i missing something?

regards
arved
Comment 3 Alan Eldridge 2002-09-09 00:45:18 UTC
On Mon, Sep 09, 2002 at 01:40:05AM +0200, Tilman Linneweh wrote:
>Hello Alan,
>
>* Alan E <alane@geeksrus.net> [Sun, 8 Sep 2002 19:35:04 -0400]:
>
>> On Mon, Sep 09, 2002 at 01:26:47AM +0200, Tilman Linneweh wrote:
>> >diff -u -r1.21 Makefile
>> >--- Makefile	31 Aug 2002 00:13:22 -0000	1.21
>> >+++ Makefile	8 Sep 2002 23:22:52 -0000
>> >@@ -17,6 +17,7 @@
>> > 
>> > USE_XLIB=	yes
>> > USE_GNOMENG=	yes
>> >+USE_GNOME=	gtk12
>> 
>> shouldn't that be += ???
>
>I don't think so..there isn't a possibility that anything is added to USE_GNOME
>before this (slaveports or something like that). Or am i missing something?

The command line to make?
-- 
Alan Eldridge
Unix/C(++) IT Pro, 20 yrs, seeking new employment.
(http://wwweasel.geeksrus.net/~alane/resume.txt)
KDE, KDE-FreeBSD Teams (http://www.kde.org, http://freebsd.kde.org/)
Comment 4 Tilman Linneweh 2002-09-09 00:58:01 UTC
* Alan E <alane@geeksrus.net> [Sun, 8 Sep 2002 19:45:18 -0400]:
> >> >diff -u -r1.21 Makefile
> >> >--- Makefile	31 Aug 2002 00:13:22 -0000	1.21
> >> >+++ Makefile	8 Sep 2002 23:22:52 -0000
> >> >@@ -17,6 +17,7 @@
> >> > 
> >> > USE_XLIB=	yes
> >> > USE_GNOMENG=	yes
> >> >+USE_GNOME=	gtk12
> >> 
> >> shouldn't that be += ???
> >
> >I don't think so..there isn't a possibility that anything is added to
> > USE_GNOME
> >before this (slaveports or something like that). Or am i missing something?
> 
> The command line to make?

Okay, possible, but it is IMHO useless to add unneeded dependencies on the 
commandline. (Not to mention, if we would support this, there are nearly all
ports that would need adjustment :-).

regards 
arved
Comment 5 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-09-09 02:17:24 UTC
State Changed
From-To: open->closed

Committed, thanks.