Bug 42644 - maintainer update: x11-wm/fluxbox (urgent deadlock vendor patch)
Summary: maintainer update: x11-wm/fluxbox (urgent deadlock vendor patch)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-10 18:10 UTC by hendrik
Modified: 2002-09-10 18:44 UTC (History)
0 users

See Also:

Attachments
file.diff (1.19 KB, patch)
2002-09-10 18:10 UTC, hendrik 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hendrik 2002-09-10 18:10:05 UTC 
fluxbox-0.1.11-bugfix1.patch from the vendor website introducted into
the FreeBSD ports tree some hours ago has a deadlock problem
(see website) which is fixed in the bugfix2 patch.

changes:
 - Makefile update
 - distinfo
 - pkg-descr update (independent of bugfix)

As Galeon seems to have problems pasting tabs from xterm please use
download the patch: http://www.raisdorf.net/files/FreeBSD/fluxbox-0.1.11-bugfix2.patch

How-To-Repeat: See fluxbox.sf.net for problem report
Comment 1 obraun 2002-09-10 18:22:24 UTC 
> diff -ur fluxbox-0.1.11p1/Makefile fluxbox/Makefile
> --- fluxbox-0.1.11p1/Makefile   Tue Sep 10 18:54:36 2002
> +++ fluxbox/Makefile    Tue Sep 10 18:56:07 2002
> @@ -13,7 +13,7 @@
>  MASTER_SITE_SUBDIR=    ${PORTNAME}

>  PATCH_SITES=   http://fluxbox.sourceforge.net/download/patches/
> -PATCHFILES=    fluxbox-0.1.11-bugfix1.patch
> +PATCHFILES=    fluxbox-0.1.11-bugfix2.patch
>  PATCH_DIST_STRIP=      -p1

Again, please please please please send a correct patch in the future!!!

I assume you have copy-and-pasted in X or something. Your patch does not
contain TABs were TABs are. This results in:

|diff -ur fluxbox-0.1.11p1/Makefile fluxbox/Makefile
|--- fluxbox-0.1.11p1/Makefile   Tue Sep 10 18:54:36 2002
|+++ fluxbox/Makefile    Tue Sep 10 18:56:07 2002
--------------------------
Patching file Makefile using Plan A...
Hunk #1 failed at 13.
1 out of 1 hunks failed--saving rejects to Makefile.rej

Thanks, Olli
-- 
{- IST & IIS _ INF _ UniBwM :: obraun@informatik.unibw-muenchen.de -}
{- Tele-Consulting GmbH     :: obraun@Tele-Consulting.com          -}
{- FreeBSD Commmitter       :: obraun@FreeBSD.org                  -}
Comment 2 obraun 2002-09-10 18:26:22 UTC 
* Hendrik Scholz <hendrik@scholz.net> [2002-09-10 10:03 -0700]:
> As Galeon seems to have problems pasting tabs from xterm please use
> download the patch: http://www.raisdorf.net/files/FreeBSD/fluxbox-0.1.11-=
bugfix2.patch

Hmpf, grr, sorry, I was to fast. I have not read your complete PR before
sending my previous mail.

BTW, not pasting tabs is a X problem IMO. Fix: use send-pr -a <difffile>.

Apologies, Olli
--=20
{- IST & IIS _ INF _ UniBwM :: obraun@informatik.unibw-muenchen.de -}
{- Tele-Consulting GmbH     :: obraun@Tele-Consulting.com          -}
{- FreeBSD Commmitter       :: obraun@FreeBSD.org                  -}
Comment 3 Oliver Braun freebsd_committer freebsd_triage 2002-09-10 18:43:57 UTC 
State Changed
From-To: open->closed

Committed, thanks!