Bug 46835 - Remove perl-dependancy from devel/sdl12
Summary: Remove perl-dependancy from devel/sdl12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Maxim Sobolev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-07 17:30 UTC by Ulrich Spoerlein
Modified: 2003-01-08 20:45 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Spoerlein 2003-01-07 17:30:01 UTC
The build of /usr/ports/devel/sdl12 requires perl. replace this with sed

Question: Why does this port install everything as sdl11 and not sdl12 or just sdl?

Another quirk:
sdl11-config --libs on -STABLE gives -L/usr/local/lib -Wl,-rpath,/usr/local/lib -lSDL-1.1 -pthread
sdl11-config --libs on -CURRENT gives -L/usr/local/lib -Wl,-rpath,/usr/local/lib -lSDL-1.1 -lc_r

This breaks linking against libSDL, because several pthread_ functions are unresolved
(Noticed with updated QuakeForge port (not yet committed))

Fix: Apply attached patch.



--=.5duth(d:g74SOa
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+Gw2emArGtfDbn0QRAoSXAKDXpGgWngs8AArFJHU4fsA7qc5hJwCeM0IU
UmhMYAhGMMcCubD7skj4o8g=
=gZ1L
-----END PGP SIGNATURE-----

--=.5duth(d:g74SOa----CLDySiFKbVSivLbU2hGXWijVbLgfvke3Nda4Ds8NFUaEgfKa
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig	Tue Jan  7 16:48:26 2003
+++ Makefile	Tue Jan  7 17:19:11 2003
@@ -20,6 +20,7 @@
 
 INSTALLS_SHLIB=	yes
 USE_LIBTOOL=	yes
+USE_REINPLACE=	yes
 CONFIGURE_ENV=	NASM="${LOCALBASE}/bin/nasm" \
 		PTHREAD_CFLAGS="${PTHREAD_CFLAGS}" \
 		PTHREAD_LIBS="${PTHREAD_LIBS}"
@@ -86,7 +87,7 @@
 	@cd ${WRKSRC} && \
 		${CP} sdl-config sdl11-config && \
 		${CP} sdl.m4 sdl11.m4
-	@${PERL} -pi -e 's|^deplibs_check_method=.*|deplibs_check_method=pass_all|' \
+	@${SED} -ine 's|^deplibs_check_method=.*|deplibs_check_method=pass_all|' \
 		${WRKSRC}/libtool
 
 post-install:
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2003-01-07 21:31:23 UTC
Responsible Changed
From-To: freebsd-ports->sobomax

Over to Maintainer
Comment 2 corecode@corecode.ath.cx 2003-01-08 01:01:45 UTC
Lately Ulrich Spoerlein <q@uni.de> told:

> The build of /usr/ports/devel/sdl12 requires perl. replace this with
> sed
[...]
> --- Makefile.orig	Tue Jan  7 16:48:26 2003
> +++ Makefile	Tue Jan  7 17:19:11 2003
> @@ -20,6 +20,7 @@
>  
>  INSTALLS_SHLIB=	yes
>  USE_LIBTOOL=	yes
> +USE_REINPLACE=	yes

when you're using ${REINPLACE}...

[...]
> -	@${PERL} -pi -e 's|^deplibs_check_method=.*|deplibs_check_method=pass_all|' \
> +	@${SED} -ine 's|^deplibs_check_method=.*|deplibs_check_method=pass_all|' \

..then why don't you use it?
should be @${REINPLACE_CMD} -e .... i guess

cheers
  simon

-- 
/"\   http://corecode.ath.cx/#donate
\ /
 \     ASCII Ribbon Campaign
/ \  Against HTML Mail and News
Comment 3 Maxim Sobolev freebsd_committer freebsd_triage 2003-01-08 20:43:53 UTC
State Changed
From-To: open->closed

Committed, thanks!