evilbar is a minimalist statusbar originally designed to suit the simplistic window manager evilwm. It contains the most essential tools for the desktop - a clock, XMMS control and optionally APM status. Using keyboard controls it is possible to control the most commonly used functions of XMMS.
Gah! Typo in Makefile. < CONFIGURE_ARGS+= --disable-xxms > CONFIGURE_ARGS+= --disable-xmms .. I'm so sorry. --jens
Lately Jens Arnfast told: > sed 's/^X//' >evilbar/pkg-plist << 'END-of-evilbar/pkg-plist' > Xbin/evilbar > Xbin/launch_evilbar > Xman/man1/evilbar.1 > Xman/man1/launch_evilbar.1 man pages shouldn't appear in plist; instead, use ${MAN1} > sed 's/^X//' >evilbar/Makefile << 'END-of-evilbar/Makefile' [...] > X.include <bsd.port.pre.mk> what for? > X.if defined(WITHOUT_XMMS) > XCONFIGURE_ARGS+= --disable-xxms > X.endif doesn't that interfere with build and run depends? [...] > Xpre-extract: pre-everything:: ? cheers simon -- /"\ http://corecode.ath.cx/#donate \ / \ ASCII Ribbon Campaign / \ Against HTML Mail and News
Hi Simon, thanks for your reply. As you clearly discovered this is my first time creating a port :) Simon 'portlint' Schubert wrote: > Lately Jens Arnfast told: [snip] > man pages shouldn't appear in plist; instead, use ${MAN1} Looks like I didn't read the plist chapter of Porter's Handbook thoroughly. I'll remove the mans from plist and instead use ${MAN1} >>X.include <bsd.port.pre.mk> > what for? It seemed right at the time :) I think I got the idea that @${ECHO_MSG} required the pre.mk >>X.if defined(WITHOUT_XMMS) >>XCONFIGURE_ARGS+= --disable-xxms >>X.endif > doesn't that interfere with build and run depends? It certainly appears so. I've moved the LIB_DEPENDS and RUN_DEPENDS so they only get set if !defined(WITHOUT_XMMS) >>Xpre-extract: > pre-everything:: ? Once again you're right :) (fixed) So.. now I have an new, improved and hopefully more correct Makefile - what do I do with that? Send it to you or a new send-pr? Cheers, -jens
Allright, let's try with a new improved port :-) The following shar obsoletes the original shar in this pr. Thank you for your patience Regards, -jens # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # evilbar # evilbar/pkg-comment # evilbar/pkg-plist # evilbar/distinfo # evilbar/Makefile # evilbar/pkg-descr # echo c - evilbar mkdir -p evilbar > /dev/null 2>&1 echo x - evilbar/pkg-comment sed 's/^X//' >evilbar/pkg-comment << 'END-of-evilbar/pkg-comment' XMinimalistic statusbar with XMMS control, APM status and clock END-of-evilbar/pkg-comment echo x - evilbar/pkg-plist sed 's/^X//' >evilbar/pkg-plist << 'END-of-evilbar/pkg-plist' Xbin/evilbar Xbin/launch_evilbar END-of-evilbar/pkg-plist echo x - evilbar/distinfo sed 's/^X//' >evilbar/distinfo << 'END-of-evilbar/distinfo' XMD5 (evilbar-1.2.0.tar.gz) = 8c99e3617adc277bb65471fbf2f579cb END-of-evilbar/distinfo echo x - evilbar/Makefile sed 's/^X//' >evilbar/Makefile << 'END-of-evilbar/Makefile' X# New ports collection makefile for: evilbar X# Date created: 31 Januar 2003 X# Whom: Jens Arnfast <jens@arnfast.net> X# X# $FreeBSD$ X# X XPORTNAME= evilbar XPORTVERSION= 1.2.0 XCATEGORIES+= audio sysutils x11-clocks XMASTER_SITES= http://arnfast.net/projects/ X XMAINTAINER?= jens@arnfast.net X XHAS_CONFIGURE= yes X XMAN1= evilbar.1 launch_evilbar.1 X X.if !defined(WITHOUT_XMMS) XBUILD_DEPENDS+= xmms:${PORTSDIR}/multimedia/xmms XRUN_DEPENDS+= xmms:${PORTSDIR}/multimedia/xmms X.else XCONFIGURE_ARGS+= --disable-xmms X.endif X X.if defined(WITH_APM) XCONFIGURE_ARGS+= --enable-apm X.endif X Xpre-everything: X.if !defined(WITHOUT_XMMS) X @${ECHO_MSG} X @${ECHO_MSG} "You can disable XMMS control by defining WITHOUT_XMMS." X.endif X.if !defined(WITH_APM) X @${ECHO_MSG} X @${ECHO_MSG} "You can enable APM status by defining WITH_APM." X.endif X @${ECHO_MSG} X X.include <bsd.port.mk> END-of-evilbar/Makefile echo x - evilbar/pkg-descr sed 's/^X//' >evilbar/pkg-descr << 'END-of-evilbar/pkg-descr' Xevilbar is a minimalistic ncurses-based statusbar Xwith XMMS control, APM status and a clock. X XWWW: http://arnfast.net/evilbar/ X X-- Jens Arnfast <jens@arnfast.net> END-of-evilbar/pkg-descr exit
State Changed From-To: open->analyzed There are a couple of issues with disabling XMMS support that I will sort out with the author.
Responsible Changed From-To: freebsd-ports-bugs->roam I'll take care of this.
On Sun, Feb 02, 2003 at 02:10:14PM -0800, Jens Arnfast wrote: > > Allright, let's try with a new improved port :-) > > The following shar obsoletes the original shar in this pr. Hi, Unfortunately, there are a couple of problems with your port (or maybe with the evilbar source itself) when XMMS support is disabled. Attached is a patch to the evilbar source, which does several things: - moves the --disable-xmms check above the actual xmms-config path search; - moves the --disable-apm check along with the --disable-xmms one as close to the start as possible, just in case; - changes the two checks to use $enableval instead of $enable_optname, because the latter is not always defined; - sets PATH_XMMSCONFIG to 'true' instead of 'no' in the --disable-xmms case, since 'no --cflags' and 'no --libs' would break the build; - encloses the whole xmmsc.c in an #ifdef USE_XMMS; it would be better to exclude it from the build altogether, but this would require more invasive changes to the Makefile. Keep up the good work! G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 If I were you, who would be reading this sentence?
Peter Pentchev wrote: > Unfortunately, there are a couple of problems with your port (or maybe > with the evilbar source itself) when XMMS support is disabled. Attached > is a patch to the evilbar source, which does several things: > - moves the --disable-xmms check above the actual xmms-config path > search; > - moves the --disable-apm check along with the --disable-xmms one as > close to the start as possible, just in case; > - changes the two checks to use $enableval instead of $enable_optname, > because the latter is not always defined; > - sets PATH_XMMSCONFIG to 'true' instead of 'no' in the --disable-xmms > case, since 'no --cflags' and 'no --libs' would break the build; > - encloses the whole xmmsc.c in an #ifdef USE_XMMS; it would be better > to exclude it from the build altogether, but this would require more > invasive changes to the Makefile. Ah .. that makes perfect sense :) I disregarded your last point and implemented the changes you sent me. I also corrected a few other #ifdef bugs in the code and bumped the revision up to 1.2.1 Attached is a patch to the evilbar/Makefile and evilbar/distinfo Thank you for the extensive help :-) Cheers, -jens
State Changed From-To: analyzed->closed Oops; I actually committed the new port two days ago, yet forgot to close this PR :) Thanks for your submission!