Bug 47816 - [Maintainer Update] sysutils/thefish to 0.3
Summary: [Maintainer Update] sysutils/thefish to 0.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-02 18:20 UTC by Miguel Mendez
Modified: 2003-02-02 23:06 UTC (History)
0 users

See Also:


Attachments
thefish.diff (5.41 KB, patch)
2003-02-02 18:20 UTC, Miguel Mendez
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Mendez 2003-02-02 18:20:08 UTC
 Changelog:

    0.2.5.1 -> 0.3

    More code cleanup. Some GTK2 enhancements. 
	New console UI based on CDK (Curses Development Kit). 
	This release is dedicated to the 7 astronauts who died in the Columbia accident.
Comment 1 Adam Weinberger freebsd_committer 2003-02-02 19:55:07 UTC
State Changed
From-To: open->feedback

I'll take it, and enter the feedback loop. Well, the PR enters 
the feedback loop. Not me personally. That would probably hurt. 


Comment 2 Adam Weinberger freebsd_committer 2003-02-02 19:55:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->adamw

I'll take it, and enter the feedback loop. Well, the PR enters 
the feedback loop. Not me personally. That would probably hurt.
Comment 3 Adam Weinberger freebsd_committer 2003-02-02 19:56:55 UTC
When I build this -DWITH_CDK or WITH_CDK=yes make I get the gtk2
interface.

I think the offending block is at the top of ${WRKSRC}/Makefile:
.if !defined(NO_GUI)
CFLAGS+= -Wall -g -DGTK_DISABLE_DEPRECATED `pkg-config gtk+-2.0 --cflags`
.else 
CFLAGS+= -Wall -DNO_GUI
.endif

In any event, this is the output I get:

root@smacky:/usr/ports/sysutils/thefish# WITH_CDK=1 make
***********************************************************************
To build The Fish without the GTK+ UI, define NO_GUI or WITHOUT_X11
To enable the new (experimental) CDK console UI, define WITH_CDK
***********************************************************************
===>  Extracting for thefish-0.3
>> Checksum OK for thefish-0.3.tar.gz.
===>   thefish-0.3 depends on shared library: cdk - found
===>   thefish-0.3 depends on shared library: X11.6 - found
===>  Patching for thefish-0.3
===>  Configuring for thefish-0.3
===>  Building for thefish-0.3
cc -O -pipe -O -pipe -march=pentiumpro -O -pipe -march=pentiumpro -Wall -g -DGTK_DISABLE_DEPRECATED `pkg-config gtk+-2.0 --cflags` -DWITH_CDK -I/usr/local/include -c parser.c
cc -O -pipe -O -pipe -march=pentiumpro -O -pipe -march=pentiumpro -Wall -g -DGTK_DISABLE_DEPRECATED `pkg-config gtk+-2.0 --cflags` -DWITH_CDK -I/usr/local/include -c main.c
cc -O -pipe -O -pipe -march=pentiumpro -O -pipe -march=pentiumpro -Wall -g -DGTK_DISABLE_DEPRECATED `pkg-config gtk+-2.0 --cflags` -DWITH_CDK -I/usr/local/include -c gtk_ui.c
cc -O -pipe -O -pipe -march=pentiumpro -O -pipe -march=pentiumpro -Wall -g -DGTK_DISABLE_DEPRECATED `pkg-config gtk+-2.0 --cflags` -DWITH_CDK -I/usr/local/include -c cdk_ui.c
cc  `pkg-config gtk+-2.0 --libs` -L/usr/local/lib -lcdk -lncurses -o thefish parser.o main.o gtk_ui.o cdk_ui.o

# Adam


--
Adam Weinberger
vectors.cx	>>	adam@vectors.cx
FreeBSD.org	<<	adamw@FreeBSD.ORG
Bayer Berkeley	>>	adam.weinberger.b@bayer.com
#vim:set ts=8: 8-char tabs prevent tooth decay.
Comment 4 Miguel Mendez 2003-02-02 20:11:49 UTC
On Sun, 2 Feb 2003 11:56:55 -0800
Adam Weinberger <adamw@FreeBSD.ORG> wrote:

Hi,

> When I build this -DWITH_CDK or WITH_CDK=yes make I get the gtk2
> interface.

That's intended. WITH_CDK replaces the libdialog UI with the CDK one, it
doesn't disable X11 support. For that one would do:

$make -DWITH_CDK -DNO_GUI or make -DWITH_CDK -DWITHOUT_X11
 
Perhaps we should state that in a more explicit way, what do you think?

Cheers,
-- 
        Miguel Mendez - flynn@energyhq.homeip.net
        GPG Public Key :: http://energyhq.homeip.net/files/pubkey.txt
        EnergyHQ :: http://www.energyhq.tk
        Of course it runs NetBSD!
Comment 5 Miguel Mendez 2003-02-02 20:15:21 UTC
On Sun, 2 Feb 2003 11:56:55 -0800
Adam Weinberger <adamw@FreeBSD.ORG> wrote:

What I mean is, thefish has always shipped with 2 interfaces, X11 and
console. Disabling X11 left the console one, but, when X11 interface is
built-in, you can always use the console UI, either if DISPLAY is not
set, or forcing it with the -c argument.

Cheers,
-- 
        Miguel Mendez - flynn@energyhq.homeip.net
        GPG Public Key :: http://energyhq.homeip.net/files/pubkey.txt
        EnergyHQ :: http://www.energyhq.tk
        Of course it runs NetBSD!
Comment 6 Adam Weinberger freebsd_committer 2003-02-02 23:05:07 UTC
State Changed
From-To: feedback->closed

Committed, thanks! 

Just something to think about: when the program starts up for me now, 
the window is rather small and must be expanded. This began 2 releases 
ago.