Bug 50835 - cdrtools port uses the config path "/etc/default/cdrecord"
Summary: cdrtools port uses the config path "/etc/default/cdrecord"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Marius Strobl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-11 20:40 UTC by David E. O'Brien
Modified: 2004-04-24 14:02 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David E. O'Brien freebsd_committer freebsd_triage 2003-04-11 20:40:04 UTC
	
	cdrecord shouldn't be looking to "/etc/default/cdrecord" for its
	config file.  it should be somewhere under {PREFIX} or /etc/defaults

How-To-Repeat: 	
	strings /usr/local/bin/cdrecord |grep etc
	man cdrecord
Comment 1 DerekYoung 2003-04-12 01:20:47 UTC
Cdrecord wasn't the only utility in there that had that 
problem.  
 
Anyway, here are some patches you can use if you want, 
just copy them into  
your files directory and you will be good to go. Even the 
man pages are  
updated. I moved it all to /usr/local/etc. If you do not like 
that, change  
the patches ;) 
 
Derek Young 
 
-------------------------------START patch-da 
*** cdrecord/cdrecord.1.orig    Tue Dec 24 09:28:40 2002 
--- cdrecord/cdrecord.1 Fri Apr 11 17:04:40 2003 
*************** 
*** 146,152 **** 
  described below. 
 
  .PP 
! If a file /etc/default/cdrecord exists, the parameter to the 
  .B dev= 
  option may also be a drive name label in said file (see 
FILES section). 
 
--- 146,152 ---- 
  described below. 
 
  .PP 
! If a file /usr/local/etc/cdrecord exists, the parameter to 
the 
  .B dev= 
  option may also be a drive name label in said file (see 
FILES section). 
 
*************** 
*** 621,627 **** 
  .B dev= 
  option does not contain the characters ',', '/', '@' or ':', 
  it is interpreted as an label name that may be found in 
the file 
! /etc/default/cdrecord (see FILES section). 
  .TP 
  .BI gracetime= # 
  Set the grace time before starting to write to 
--- 621,627 ---- 
  .B dev= 
  option does not contain the characters ',', '/', '@' or ':', 
  it is interpreted as an label name that may be found in 
the file 
! /usr/local/etc/cdrecord (see FILES section). 
  .TP 
  .BI gracetime= # 
  Set the grace time before starting to write to 
*************** 
*** 1361,1367 **** 
  .TP 
  .B CDR_DEVICE 
  This may either hold a device identifier that is suitable to 
the open 
! call of the SCSI transport library or a label in the file  
/etc/default/cdrecord. 
  .TP 
  .B CDR_SPEED 
  Sets the default speed value for writing (see also 
--- 1361,1367 ---- 
  .TP 
  .B CDR_DEVICE 
  This may either hold a device identifier that is suitable to 
the open 
! call of the SCSI transport library or a label in the file  
/usr/local/etc/cdrecord. 
  .TP 
  .B CDR_SPEED 
  Sets the default speed value for writing (see also 
*************** 
*** 1417,1424 **** 
 
  .SH FILES 
  .TP 
! /etc/default/cdrecord 
! Default values can be set for the following options in  
/etc/default/cdrecord. 
  For example: 
  .SM CDR_FIFOSIZE=8m 
  or 
--- 1417,1424 ---- 
 
  .SH FILES 
  .TP 
! /usr/local/etc/cdrecord 
! Default values can be set for the following options in  
/usr/local/etc/cdrecord. 
  For example: 
  .SM CDR_FIFOSIZE=8m 
  or 
*************** 
*** 1427,1433 **** 
  .TP 
  CDR_DEVICE 
  This may either hold a device identifier that is suitable to 
the open 
! call of the SCSI transport library or a label in the file  
/etc/default/cdrecord 
  that allows to identify a specific drive on the system. 
  .TP 
  CDR_SPEED 
--- 1427,1433 ---- 
  .TP 
  CDR_DEVICE 
  This may either hold a device identifier that is suitable to 
the open 
! call of the SCSI transport library or a label in the file  
/usr/local/etc/cdrecord 
  that allows to identify a specific drive on the system. 
  .TP 
  CDR_SPEED 
 
 
-------------------------------START patch-db 
*** cdrecord/defaults.c.orig    Wed Aug 14 12:52:00 2002 
--- cdrecord/defaults.c Fri Apr 11 17:11:51 2003 
*************** 
*** 53,59 **** 
         * don't contribute work and don't give support, they 
are causing extra 
         * work for me and this way slow down the cdrecord 
development. 
         */ 
!       return (defltopen("/etc/default/cdrecord")); 
  } 
 
  EXPORT void 
--- 53,59 ---- 
         * don't contribute work and don't give support, they 
are causing extra 
         * work for me and this way slow down the cdrecord 
development. 
         */ 
!       return (defltopen("/usr/local/etc/cdrecord")); 
  } 
 
  EXPORT void 
 
 
-------------------------------START patch-dc 
*** cdrecord/cdrecord.dfl.orig  Sun Jul  7 16:56:21 2002 
--- cdrecord/cdrecord.dfl       Fri Apr 11 17:13:58 2003 
*************** 
*** 1,6 **** 
  #ident @(#)cdrecord.dfl       1.4 02/07/07 Copyr 1998 J. 
Schilling 
  # 
! # This file is /etc/default/cdrecord 
  # It contains defaults that are used if no command line 
option 
  # or environment is present. 
  # 
--- 1,6 ---- 
  #ident @(#)cdrecord.dfl       1.4 02/07/07 Copyr 1998 J. 
Schilling 
  # 
! # This file is /usr/local/etc/cdrecord 
  # It contains defaults that are used if no command line 
option 
  # or environment is present. 
  # 
*************** 
*** 14,20 **** 
  # Note that newer cdrecord versions do not default 
  # to speed=1. For MMC compliant drives, the default 
  # is to write at maximum speed, so it in general does 
! # not make sense to set up a default speed in 
/etc/default/cdrecord 
  # 
  #CDR_SPEED=40 
 
--- 14,20 ---- 
  # Note that newer cdrecord versions do not default 
  # to speed=1. For MMC compliant drives, the default 
  # is to write at maximum speed, so it in general does 
! # not make sense to set up a default speed in 
/usr/local/etc/cdrecord 
  # 
  #CDR_SPEED=40 
 
 
-------------------------------START patch-dd 
*** readcd/readcd.1.orig        Tue Dec 24 09:28:41 2002 
--- readcd/readcd.1     Fri Apr 11 17:21:57 2003 
*************** 
*** 186,192 **** 
  .B dev= 
  option does not contain the characters ',', '/', '@' or ':', 
  it is interpreted as an label name that may be found in 
the file 
! /etc/default/cdrecord (see FILES section). 
  .TP 
  .BI timeout= # 
  Set the default SCSI command timeout value to 
--- 186,192 ---- 
  .B dev= 
  option does not contain the characters ',', '/', '@' or ':', 
  it is interpreted as an label name that may be found in 
the file 
! /usr/local/etc/cdrecord (see FILES section). 
  .TP 
  .BI timeout= # 
  Set the default SCSI command timeout value to 
 
 
-------------------------------START patch-de 
*** scgcheck/scgcheck.1.orig    Tue Dec 24 09:32:01 2002 
--- scgcheck/scgcheck.1 Fri Apr 11 17:25:25 2003 
*************** 
*** 170,176 **** 
  .B dev= 
  option does not contain the characters ',', '/', '@' or ':', 
  it is interpreted as an label name that may be found in 
the file 
! /etc/default/cdrecord (see FILES section). 
  .TP 
  .BI timeout= # 
  Set the default SCSI command timeout value to 
--- 170,176 ---- 
  .B dev= 
  option does not contain the characters ',', '/', '@' or ':', 
  it is interpreted as an label name that may be found in 
the file 
! /usr/local/etc/cdrecord (see FILES section). 
  .TP 
  .BI timeout= # 
  Set the default SCSI command timeout value to 
 
-------------------------------START patch-df 
*** cdda2wav/cdda2ogg.orig      Tue Apr  9 06:18:15 2002 
--- cdda2wav/cdda2ogg   Fri Apr 11 17:31:24 2003 
*************** 
*** 33,39 **** 
 
  FILEPREFIX=${1:-audiotrack} 
 
! . /etc/default/cdda2ogg 2>/dev/null || true 
 
  TRACK=1 
  while : 
--- 33,39 ---- 
 
  FILEPREFIX=${1:-audiotrack} 
 
! . /usr/local/etc/cdda2ogg 2>/dev/null || true 
 
  TRACK=1 
  while : 
 
 
-------------------------------START patch-dg 
*** include/deflts.h.orig       Mon Aug 26 06:00:36 2002 
--- include/deflts.h    Fri Apr 11 17:33:00 2003 
*************** 
*** 34,40 **** 
  extern "C" { 
  #endif 
 
! #define       DEFLT   "/etc/default" 
   
  /* 
   * cmd's to defltcntl() 
--- 34,40 ---- 
  extern "C" { 
  #endif 
 
! #define       DEFLT   "/usr/local/etc" 
   
  /* 
   * cmd's to defltcntl() 
 
-------------------------------START patch-dh 
*** rscsi/rscsi.c.orig  Sat Nov 30 05:48:40 2002 
--- rscsi/rscsi.c       Fri Apr 11 17:34:19 2003 
*************** 
*** 132,140 **** 
         * don't contribute work and don't give support, they 
are causing extra 
         * work for me and this way slow down the 
development. 
         */ 
!       if (defltopen("/etc/default/rscsi") < 0) { 
                rscsierror(geterrno(), errmsgstr(geterrno()), 
!                       "Remote configuration error: Cannot open 
/etc/default/rscsi"); 
  /*            rscsirespond(-1, geterrno());*/ 
                exit(EX_BAD); 
        } 
--- 132,140 ---- 
         * don't contribute work and don't give support, they 
are causing extra 
         * work for me and this way slow down the 
development. 
         */ 
!       if (defltopen("/usr/local/etc/rscsi") < 0) { 
                rscsierror(geterrno(), errmsgstr(geterrno()), 
!                       "Remote configuration error: Cannot open 
/usr/local/etc/rscsi"); 
  /*            rscsirespond(-1, geterrno());*/ 
                exit(EX_BAD); 
        } 
 
 
-------------------------------START patch-di 
*** rscsi/rscsi.dfl.orig        Mon Nov 13 19:24:03 2000 
--- rscsi/rscsi.dfl     Fri Apr 11 17:35:22 2003 
*************** 
*** 1,6 **** 
  #ident %Z%%M% %I% %E% Copyr 2000 J. Schilling 
  # 
! # This file is /etc/default/rscsi 
  # 
  # NOTE: If this file is not present, rscsi will reject to 
work. 
  # 
--- 1,6 ---- 
  #ident %Z%%M% %I% %E% Copyr 2000 J. Schilling 
  # 
! # This file is /usr/local/etc/rscsi 
  # 
  # NOTE: If this file is not present, rscsi will reject to 
work. 
  # 

This message was sent from the free private e-mail service by easy.com, the portal site owned by Stelios and the easyGroup. This email service is available to all members of the public to use for personal reasons only.  Not all subscribers to this e-mail service are representatives of an easyGroup company.
Comment 2 DerekYoung 2003-04-12 01:59:15 UTC
Ok.. remind me not to cut and paste a patch into an email 
when I am on vacation.. i went ahead and uploded a tar of 
them. rofl. 
 
http://www.orcacom.net/~bleach/cdrtools.tar 
 
Sorry. 
 
Derek Young 
bleach@orcacom.net 

This message was sent from the free private e-mail service by easy.com, the portal site owned by Stelios and the easyGroup. This email service is available to all members of the public to use for personal reasons only.  Not all subscribers to this e-mail service are representatives of an easyGroup company.
Comment 3 David E. O'Brien freebsd_committer freebsd_triage 2003-04-12 17:59:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dirk

Dirk is the maintainer.
Comment 4 marius 2004-01-06 13:26:39 UTC
For the record, this is properly dealt with in sysutils/cdrtools-devel in
a way that obeys the license in cdrecord/defaults.c an can be merged into
sysutils/cdrtools.
Comment 5 Kris Kennaway freebsd_committer freebsd_triage 2004-02-22 02:01:50 UTC
Responsible Changed
From-To: dirk->freebsd-ports-bugs

dirk no longer maintains this port
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2004-03-14 00:36:01 UTC
State Changed
From-To: open->feedback

Has this problem been taken care of now that the maintainership 
of this port has been reset?
Comment 7 Alexander Leidinger freebsd_committer freebsd_triage 2004-03-17 14:35:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marius@alchemy.franken.de

Marius is now the new maintainer of the port. Hand over the PR 
too.
Comment 8 Pav Lucistnik freebsd_committer freebsd_triage 2004-04-10 16:48:37 UTC
Responsible Changed
From-To: marius@alchemy.franken.de->freebsd-ports-bugs

You can't assign a non-FreeBSD.org address as a Responsible:
Comment 9 Mark Linimon freebsd_committer freebsd_triage 2004-04-20 20:36:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marius

Note that Marius and Marius are the same person. 

Marius, you might want to change your email address as maintainer 
to be your @FreeBSD.org address, to make it easier to understand 
how to assign PRs for this port.
Comment 10 Marius Strobl freebsd_committer freebsd_triage 2004-04-24 13:57:40 UTC
State Changed
From-To: feedback->closed


Local changes of sysutils/cdrtools-devel were merged into sysutils/cdrtools.