Bug 54304 - PATCH: add WITHOUT_GUI knob to multimedia/smpeg
Summary: PATCH: add WITHOUT_GUI knob to multimedia/smpeg
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-10 06:00 UTC by Josh Elsasser
Modified: 2003-07-15 07:22 UTC (History)
0 users

See Also:


Attachments
file.diff (938 bytes, patch)
2003-07-10 06:00 UTC, Josh Elsasser
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Elsasser 2003-07-10 06:00:32 UTC
	The smpeg library has an optional GTK player program which the
multimedia/smpeg port always builds, creating a dependency on GTK.
This patch adds a WITHOUT_GUI knob to control building of that
optional program.
Comment 1 tkato 2003-07-10 09:01:43 UTC
Well, it should be better to utilize WANT_GNOME funtcion in
this case.


diff -urN /usr/ports/multimedia/smpeg/Makefile multimedia/smpeg/Makefile
--- /usr/ports/multimedia/smpeg/Makefile	Mon Apr 21 12:24:59 2003
+++ multimedia/smpeg/Makefile	Thu Jul 10 16:44:49 2003
@@ -21,8 +21,9 @@
 
 SDL_CONFIG=	${LOCALBASE}/bin/sdl11-config
 
+WANT_GNOME=	yes
+USE_REINPLACE=	yes
 USE_GMAKE=	yes
-USE_GNOME=	gtk12
 USE_LIBTOOL=	yes
 INSTALLS_SHLIB=	yes
 CONFIGURE_ENV=	SDL_CONFIG="${SDL_CONFIG}" \
@@ -37,8 +38,16 @@
 
 MAN1=		gtv.1 plaympeg.1
 
+.include <bsd.port.pre.mk>
+
+.if ${HAVE_GNOME:Mgtk12}!=""
+USE_GNOME+=	gtk12
+.else
+CONFIGURE_ARGS+=	--disable-gtk-player
+.endif
+
 post-configure:
-	@${PERL} -pi -e 's|^deplibs_check_method=.*|deplibs_check_method=pass_all|' \
+	@${REINPLACE_CMD} -e 's|^deplibs_check_method=.*|deplibs_check_method=pass_all|' \
 		${WRKSRC}/libtool
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
diff -urN /usr/ports/multimedia/smpeg/pkg-plist multimedia/smpeg/pkg-plist
--- /usr/ports/multimedia/smpeg/pkg-plist	Fri Apr  6 22:40:22 2001
+++ multimedia/smpeg/pkg-plist	Thu Jul 10 16:44:19 2003
@@ -1,4 +1,4 @@
-bin/gtv
+%%GNOME:%%bin/gtv
 bin/plaympeg
 bin/smpeg-config
 include/smpeg/MPEG.h
Comment 2 Daichi GOTO freebsd_committer freebsd_triage 2003-07-15 07:21:55 UTC
State Changed
From-To: open->closed

Committed. Thanks!