Bug 58317 - [patch] add GCCVERSION makevar to bsd.port.mk
Summary: [patch] add GCCVERSION makevar to bsd.port.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-21 05:10 UTC by Mark Linimon
Modified: 2003-11-07 08:57 UTC (History)
0 users

See Also:

Attachments
file.diff (1.64 KB, patch)
2003-10-21 05:10 UTC, Mark Linimon 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon 2003-10-21 05:10:05 UTC 
	Recent bento build logs reflect the fact that many ports were
	broken by the gcc3.3 import.  In many of these, myself and
	others have added a conditional evaluation of BROKEN, using
	OSVERSION as a proxy for "when GCCx.y was imported".  However,
	few people remember to look up the exact version, and in
	general just use 501000.  The following patch removes the need
	to use a proxy, and in addition gets the answer exactly right.

	Thus, port Makefiles can be changed from the following:

	.if ${OSVERSION} >= 501000
	BROKEN=	"will not compile on FreeBSD version ${OSVERSION}
	.endif

	to

	.if ${GCCVERSION} >= 303000
	BROKEN=	"will not compile using gcc version ${GCCVERSION}
	.endif

How-To-Repeat: 	(n/a)
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2003-10-21 05:28:53 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

It deals with bsd.port.mk, so it must be a portmgr deal.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-01 20:41:17 UTC 
State Changed
From-To: open->analyzed

This is currently being tested on bento.
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 5 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 6 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 7 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 8 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Fixed with the comment made in the follow-up.  Thanks for reporting.
Comment 9 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 10 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 11 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 12 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed with the additional check of INSTALL_AS_USER.  Thanks!
Comment 13 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 14 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 15 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 16 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 17 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 18 Joe Marcus Clarke freebsd_committer freebsd_triage 2003-11-07 08:52:50 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!