Bug 58939 - [patch] dumb little hack for /etc/rc.firewall{,6}
Summary: [patch] dumb little hack for /etc/rc.firewall{,6}
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 4.9-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-rc (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2003-11-04 21:40 UTC by David Wolfskill
Modified: 2024-01-20 22:52 UTC (History)
3 users (show)

See Also:


Attachments
file.diff (1.27 KB, patch)
2003-11-04 21:40 UTC, David Wolfskill
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Wolfskill 2003-11-04 21:40:17 UTC
	Basic problem is that I sometimes make mistakes that are obvious
	in retrospect.  :-}  So I tend to hack the firewall script with
	which I start to add at "-t" flag, which prefixes each command
	with "echo".  That way, when it's run with "-t", I can see
	what ipfw (or ip6fw) commands will be executed.

	Basically, I thought that this might be useful to others.  And
	yeah, I got tired of hacking it in myself each time.  :-}

	If all else fails, consider it a teaching aid.  :-)

Fix: Here you go.  I haven't actually used the rc.firewall6, but
	after hacking it, I did verify that I could make it spit
	out commands (and that they even looked plausible).

	Oh -- sorry; I don't have immediate access to a powered-on
	-CURRENT box right now.  The below ought to work just fine in
	-CURRENT, though.

	And my feelings won't be hurt if you use a different way to
	cause the "test" invocation.  "-t" just seemed mnemonic to me.
	Season to taste; serve when done well.
How-To-Repeat: 	N/A
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2006-06-29 01:31:00 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-rc

Over to maintainer(s).
Comment 2 Chris Rees freebsd_committer freebsd_triage 2012-10-27 17:26:22 UTC
State Changed
From-To: open->analyzed

I think that this could be useful.  Instead though I've made it just 
depend on the value of $firewall_test; for example that could go into 
rc.conf.  Would you still like to see this go in? 

http://www.bayofrum.net/~crees/patches/58939.diff
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2018-05-28 19:44:32 UTC
batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.
Comment 4 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:36:32 UTC
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 5 Warner Losh freebsd_committer freebsd_triage 2024-01-16 05:43:36 UTC
Cc:ing David's current account. I think this is long since OBE.
There's no rc.firewall6 anymore, for example.

I'll let David decide whether or not to keep this open or not, but I'd recommend just closing it.
Comment 6 Warner Losh freebsd_committer freebsd_triage 2024-01-16 05:47:00 UTC
(In reply to Warner Losh from comment #5)
Hmmm, Chris' patch looks to be good and in the modern style. But I'll still let dhw decide :)
Comment 7 david 2024-01-20 22:52:16 UTC
Just back from being off-Net for a fortnight or so, so it's plausible a grain or two of salt is appropriate.  That said, if others find the general idea useful, I think it would be worth implementing.

I'm quite agnostic about the implementation details: Chris's approach is fine for me.