Bug 59187 - Maintainer update: java/java-checkstyle
Summary: Maintainer update: java/java-checkstyle
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-11 20:10 UTC by Dave Glowacki
Modified: 2003-12-15 18:04 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (1.26 KB, patch)
2003-11-11 20:10 UTC, Dave Glowacki 		no flags Details | Diff
ckstyle.patch (1.59 KB, patch)
2003-12-03 18:45 UTC, dglo 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Glowacki 2003-11-11 20:10:30 UTC 
	Update java-checkstyle port to latest version

Fix: Apply this patch:
Comment 1 Greg Lewis freebsd_committer freebsd_triage 2003-11-18 20:28:08 UTC 
State Changed
From-To: open->feedback

Dave, as it is the PR breaks the packing list since the packing list 
contains the port version (checkstyle-3.1) currently.  Can you please 
submit an updated patch which addresses this? 

Also, why are you placing the docs in a subdirectory of DOCSDIR instead 
of just DOCSDIR?  This doesn't seem to provide any benefits since one 
can only have one version of the port installed at once.  You might want 
to consider using the new PORTDOCS macro to do the documentation too, 
see databases/mysql-connector-java for an example.
Comment 2 Greg Lewis freebsd_committer freebsd_triage 2003-11-18 20:28:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->glewis

I'll take this.
Comment 3 dglo 2003-12-03 18:45:51 UTC 
Here's an updated patch:
Comment 4 Greg Lewis freebsd_committer freebsd_triage 2003-12-15 18:01:42 UTC 
State Changed
From-To: feedback->closed

Committed, thanks! 

Note: I had to move the generating of the packing list from do-install 
to pre-install.  Otherwise packaging and deinstall missed files. 
There is a note in bsd.port.mk which reads: 

If you are generating the packing list on-the-fly, make sure it's 
generated before do-install is called! 

Might be useful for future reference :).