Responsible Changed From-To: freebsd-ports-bugs->marcus I'll take this.
State Changed From-To: open->feedback You should probably do some kind of auto-detection similar to the way www/epiphany works so that you detect mozilla-devel as well. Also, you do not need to explicitly list out all those GNOME components. See http://www.freebsd.org/gnome/docs/porting.html for a guide. Also, the plist needs to be sorted, and you don't need to specify GNU_CONFIGURE if your port uses libtool. Passing PREFIX to CONFIGURE_ARGS is also not needed.
I have corrected the aforementioned problems. Note that I only let the user choose a gtk2 mozilla, as the port uses GNOME 2 components. # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # mozilla-bonobo # mozilla-bonobo/Makefile # mozilla-bonobo/pkg-plist # mozilla-bonobo/pkg-descr # mozilla-bonobo/distinfo # echo c - mozilla-bonobo mkdir -p mozilla-bonobo > /dev/null 2>&1 echo x - mozilla-bonobo/Makefile sed 's/^X//' >mozilla-bonobo/Makefile << 'END-of-mozilla-bonobo/Makefile' X# New ports collection makefile for: mozilla-bonobo X# Date created: 20 Nov 2003 X# Whom: Jean-Yves Lefort <jylefort@brutele.be> X# X# $FreeBSD$ X# X XPORTNAME= mozilla-bonobo XPORTVERSION= 0.4.0 XCATEGORIES= www XMASTER_SITES= ${MASTER_SITE_SAVANNAH} XMASTER_SITE_SUBDIR= moz-bonobo X XMAINTAINER= jylefort@brutele.be XCOMMENT= A Netscape/Mozilla plugin using Bonobo controls to display files X XBUILD_DEPENDS= ${X11BASE}/include/mozilla${MOZILLA_BRANCH}/mozilla-config.h:${PORTSDIR }/www/mozilla-headers${MOZILLA_BRANCH} XRUN_DEPENDS= mozilla:${PORTSDIR}/www/mozilla${MOZILLA_BRANCH}-gtk2 X XUSE_X_PREFIX= yes XUSE_GNOME= gnomeprefix libgnomeui gconf2 libgnomeprint XUSE_LIBTOOL_VER= 15 XUSE_REINPLACE= yes X XCONFIGURE_ARGS= --with-plugin-install-dir=${PREFIX}/lib/browser_plugins \ X --with-mozilla-include-dir=${X11BASE}/include/mozilla${MOZILLA_BRANCH} X X.if defined(WITH_MOZILLA_DEVEL) XMOZILLA_BRANCH= -devel X.else XMOZILLA_BRANCH= X.endif X Xpre-everything:: X.if ! defined(WITH_MOZILLA_DEVEL) X @${ECHO_MSG} "" X @${ECHO_MSG} "By default, this port uses www/mozilla-gtk2." X @${ECHO_MSG} "You may define WITH_MOZILLA_DEVEL to use www/mozilla-devel-gtk2." X @${ECHO_MSG} "" X.endif X Xpost-patch: X @${REINPLACE_CMD} -e \ X 's|\$${prefix}/doc/mozilla-bonobo|${DOCSDIR}| ; \ X s|COPYING\\|\\| ; \ X s|INSTALL\\|\\| ; \ X s|TODO\\|TODO| ; \ X s|ABOUT-NLS||' ${WRKSRC}/Makefile.in X.if defined(NOPORTDOCS) X @${REINPLACE_CMD} -e \ X 's|\$$(libmozilla_bonobodoc_DATA)|| ; \ X s|\$$(mkinstalldirs) \$$(DESTDIR)\$$(libmozilla_bonobodocdir)|| ; \ X s| \$$(DESTDIR)\$$(libmozilla_bonobodocdir) | |' ${WRKSRC}/Makefile.in X.endif X X.include <bsd.port.mk> END-of-mozilla-bonobo/Makefile echo x - mozilla-bonobo/pkg-plist sed 's/^X//' >mozilla-bonobo/pkg-plist << 'END-of-mozilla-bonobo/pkg-plist' Xbin/mozilla-bonobo-viewer Xetc/gconf/gconf.xml.defaults/apps/mozilla-bonobo/%gconf.xml Xetc/gconf/gconf.xml.defaults/apps/mozilla-bonobo/mime-types/%gconf.xml Xetc/gconf/gconf.xml.defaults/schemas/apps/mozilla-bonobo/%gconf.xml Xetc/gconf/gconf.xml.defaults/schemas/apps/mozilla-bonobo/mime-types/%g conf.xml Xetc/gconf/schemas/mozilla-bonobo.schemas Xlib/browser_plugins/libmozilla_bonobo.so X%%PORTDOCS%%%%DOCSDIR%%/README X%%PORTDOCS%%%%DOCSDIR%%/AUTHORS X%%PORTDOCS%%%%DOCSDIR%%/ChangeLog X%%PORTDOCS%%%%DOCSDIR%%/NEWS X%%PORTDOCS%%%%DOCSDIR%%/TODO X@dirrm etc/gconf/gconf.xml.defaults/apps/mozilla-bonobo/mime-types X@dirrm etc/gconf/gconf.xml.defaults/apps/mozilla-bonobo X@dirrm etc/gconf/gconf.xml.defaults/schemas/apps/mozilla-bonobo/mime-types X@dirrm etc/gconf/gconf.xml.defaults/schemas/apps/mozilla-bonobo X%%PORTDOCS%%@dirrm %%DOCSDIR%% END-of-mozilla-bonobo/pkg-plist echo x - mozilla-bonobo/pkg-descr sed 's/^X//' >mozilla-bonobo/pkg-descr << 'END-of-mozilla-bonobo/pkg-descr' Xmozilla-bonobo is a netscape-compatible browser plugin which allows Xyour browser to use bonobo controls to display supported mime types. X XWWW: http://www.nongnu.org/moz-bonobo/ X X- Jean-Yves Lefort Xjylefort@brutele.be END-of-mozilla-bonobo/pkg-descr echo x - mozilla-bonobo/distinfo sed 's/^X//' >mozilla-bonobo/distinfo << 'END-of-mozilla-bonobo/distinfo' XMD5 (mozilla-bonobo-0.4.0.tar.gz) = e8080758f7319ac3255ba7cc4bdeb514 END-of-mozilla-bonobo/distinfo exit
State Changed From-To: feedback->closed Committed with more Mozilla modifications. Thanks!