Fix gcc33-issue; cpp is prying into invalid code inside of #if 0. cc:maintainer. Please consider changing mastersite to http://www.cam.cornell.edu/~adrian/units.html where more recent versions are available! Tested on: -STABLE, -CURRENT Fix: [Ab]use C++-style comments for offending section. Add new patch-file: files/patch-units.c How-To-Repeat: http://bento.freebsd.org/errorlogs/i386-5-latest/units-1.80.log
On Mon, Dec 01, 2003 at 11:20:49AM +0100, Volker Stolz wrote: >>Number: 59866 >>Category: ports >>Synopsis: [patch] math/units: Unbreak on -CURRENT (nmu) >>Release: FreeBSD 4.9-RC i386 >>Environment: > System: FreeBSD menelaos.informatik.rwth-aachen.de 4.9-RC FreeBSD 4.9-RC #10: Tue Oct 7 12:32:25 CEST 2003 root@menelaos.informatik.rwth-aachen.de:/usr/obj/usr/src/sys/MENELAOS i386 >>Description: > Fix gcc33-issue; cpp is prying into invalid code inside of #if 0. Then it is severely broken. However, your patch doesn't seem to harm anything, so I hereby approve it iff it is necessary. > cc:maintainer. Please consider changing mastersite to > http://www.cam.cornell.edu/~adrian/units.html where more recent > versions are available! Alpha versions, which are better suited for a -devel spinoff of the current port. > Tested on: -STABLE, -CURRENT >>How-To-Repeat: > http://bento.freebsd.org/errorlogs/i386-5-latest/units-1.80.log No, bento has a newer version of readline. Adrian (author, BCC'd), can you look into making the next release of units also work with the newest readline library? Thanks. -- Jason Harris | NIC: JH329, PGP: This _is_ PGP-signed, isn't it? jharris@widomaker.com | web: http://keyserver.kjsl.com/~jharris/
> >>Number: 59866 > >>Category: ports > >>Synopsis: [patch] math/units: Unbreak on -CURRENT (nmu) > > >>Release: FreeBSD 4.9-RC i386 > > >>Environment: > > System: FreeBSD menelaos.informatik.rwth-aachen.de 4.9-RC FreeBSD 4.9-RC = > #10: Tue Oct 7 12:32:25 CEST 2003 root@menelaos.informatik.rwth-aachen.de:/= > usr/obj/usr/src/sys/MENELAOS i386 > =20 > =20 > >>Description: > > Fix gcc33-issue; cpp is prying into invalid code inside of #if 0. > > Then it is severely broken. However, your patch doesn't seem to > harm anything, so I hereby approve it iff it is necessary. I have deleted the offending material from my development version because of this issue (and it wasn't a big deal to delete it). > No, bento has a newer version of readline. Adrian (author, BCC'd), > can you look into making the next release of units also work with > the newest readline library? Thanks. I'll look into this. I'm getting ready to issue a new release as soon as I have some time, actually. (No telling how soon that will actually be, though.)
State Changed From-To: open->closed Fix committed, thanks!