Bug 60377 - [patch] to make "ipfw tee" behave as intended.
Summary: [patch] to make "ipfw tee" behave as intended.
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 4.9-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andre Oppermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-18 22:50 UTC by P Kern
Modified: 2004-09-09 13:28 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (3.54 KB, patch)
2003-12-18 22:50 UTC, P Kern 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description P Kern 2003-12-18 22:50:20 UTC 
	Currently with "ipfw tee" [as noted in ipfw(8)]
	  "the search terminates and the original packet is accepted."
	Here is a patch to make "ipfw tee" behave as intended(?).
	With this patch, after a matching packet is sent to the divert
	socket, instead of terminating the search and accepting the
	packet, the search continues so that the packet is checked
	against any further IPFW rules.

	Hope this helps.

Fix: *** sys/netinet/ip_input.c	2003/12/17 16:20:23	1.1
--- sys/netinet/ip_input.c	2003/12/17 19:49:21
***************
Comment 1 Peter Pentchev freebsd_committer freebsd_triage 2003-12-19 06:55:43 UTC 
Responsible Changed
From-To: freebsd-bugs->luigi

Over to the IPFW author/maintainer.
Comment 2 P Kern 2004-01-15 21:46:31 UTC 
Sorry but this patch as it is now will break "ipfw divert".
The problem is that in the changed to ip_input.c, the final
'return;' should follow the 'if (clone != NULL) { ... }'
portion instead of being inside it.
i.e. where it now reads ....

	if (clone != NULL) {
		...
		return;
	}

... it should instead read ...

	if (clone != NULL) {
		...
	}
	return;


Sorry about that. Hope this helps. pak.
Comment 3 Andre Oppermann freebsd_committer freebsd_triage 2004-08-24 19:10:04 UTC 
Responsible Changed
From-To: luigi->andre

Take over.
Comment 4 Andre Oppermann freebsd_committer freebsd_triage 2004-09-09 13:27:06 UTC 
State Changed
From-To: open->closed

Ipfw tee will not be fixed in 4.x due to complexity.  For 5.x a fix has been prepared 
and is tracked under kern/64240.