Bug 60972 - audio/grip does not compile when "make WITH_CDPARANOIA=yes" is used
Summary: audio/grip does not compile when "make WITH_CDPARANOIA=yes" is used
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-06 09:20 UTC by Esa Karkkainen
Modified: 2004-01-06 12:51 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (598 bytes, patch)
2004-01-06 09:20 UTC, Esa Karkkainen
no flags Details | Diff
file.diff (673 bytes, patch)
2004-01-06 09:20 UTC, Esa Karkkainen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Esa Karkkainen 2004-01-06 09:20:15 UTC
Port audio/grip does not compile when "make WITH_CDPARANOIA=yes" is used

Fix: I have supplied two fixes which have same net effect.
First patch is tad strange, but passes "portlint -A". Second patch is
"traditional" fix.

---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---
---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---
How-To-Repeat: cd /usr/ports/audio/grip && make WITH_CDPARANOIA=yes all
[ snip ]
cdpar.c:47:33: cdda/cdda_interface.h: No such file or directory
cdpar.c:48:32: cdda/cdda_paranoia.h: No such file or directory
cdpar.c: In function `CDPCallback':
[ snip ]
gmake[2]: *** [cdpar.o] Error 1
gmake[2]: Leaving directory `/usr/ports/audio/grip/work/grip-3.1.4/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/audio/grip/work/grip-3.1.4'
gmake: *** [all] Error 2
*** Error code 2

Stop in /usr/ports/audio/grip.
Comment 1 tkato 2004-01-06 12:21:03 UTC
Since USE_GNOME=gnomehack implies it, adding USE_REINPLACE=yes
line is unnecessary in this case.

I guess this patch should be the most simple solution.


diff -urN /usr/ports/audio/grip/Makefile audio/grip/Makefile
--- /usr/ports/audio/grip/Makefile	Tue Jan  6 21:08:05 2004
+++ audio/grip/Makefile	Tue Jan  6 21:11:43 2004
@@ -30,4 +30,7 @@
 CONFIGURE_ARGS+=	--disable-cdpar
 .endif
 
+post-patch:
+	@${REINPLACE_CMD} -e 's|<cdda/cdda|<cdda|g' ${WRKSRC}/src/cdpar.c
+
 .include <bsd.port.mk>
Comment 2 Kirill Ponomarev freebsd_committer 2004-01-06 12:51:03 UTC
State Changed
From-To: open->closed

Committed, thanks!