Bug 61366 - [PATCH] archivers/unzip: fix bogus pkg-plist
Summary: [PATCH] archivers/unzip: fix bogus pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrey A. Chernov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-14 17:40 UTC by Matthias Andree
Modified: 2004-01-16 01:32 UTC (History)
1 user (show)

See Also:

Attachments
unzip-5.50_2.patch (1.23 KB, patch)
2004-01-14 17:40 UTC, Matthias Andree 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree 2004-01-14 17:40:03 UTC 
The current @exec/@unexec stuff is bogus.
1. it discards an error condition without reason
2. it does not properly "silence" rm errors as the last commit suggests,
   the redirection parameters are reversed. rm's stdout goes down the
   drain, rm's stderr appears on pkg_delete's stdout.
3. there is no reason to use @exec/@unexec in the first place

The patch below
A. replaces @exec/@unexec by just bin/zipinfo
B. avoids two bogus portlint "possible direct use of file(1)"
   warnings by using "f" instead of "file" for iterator variable, two
   more warnings remain unaddressed by this patch.

Port maintainer (ache@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.50
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-01-14 18:15:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ache

Over to maintainer.
Comment 2 Andrey A. Chernov freebsd_committer freebsd_triage 2004-01-16 01:32:22 UTC 
State Changed
From-To: open->closed

Committed