Bug 61659 - update port: polish/gnugadu2 to pre6
Summary: update port: polish/gnugadu2 to pre6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-21 01:20 UTC by Piotr Smyrak
Modified: 2004-01-22 09:20 UTC (History)
0 users

See Also:

Attachments
gnugadu.patch (2.36 KB, patch)
2004-01-21 01:20 UTC, Piotr Smyrak 		no flags Details | Diff
gnugadu2.patch.2 (705 bytes, application/octet-stream)
2004-01-21 22:41 UTC, Piotr Smyrak 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Smyrak 2004-01-21 01:20:06 UTC 
	The attached patch updates the polish/gnugadu2 port to 
recently released pre6 version, this is fixing lots of ugly
bugs that were introduced during pre5 release.

How-To-Repeat: 	N/A
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-01-21 19:02:01 UTC 
State Changed
From-To: open->feedback

It fails to build package: 

Creating gzip'd tar ball in '/usr/ports/polish/gnugadu2/pl-gnugadu2-esound-2.0.p6.tgz' 
tar: /usr/localshare/applnk/Internet/gg2.desktop: Cannot stat: No such file or directory 
tar: Error exit delayed from previous errors 
pkg_create: make_dist: tar command failed with code 512
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2004-01-21 20:13:10 UTC 
krion,

can you retry with this simple patch to pkg-plist?

diff -a -u -r1.4 pkg-plist
--- pkg-plist   15 Jan 2004 23:48:06 -0000      1.4
+++ pkg-plist   21 Jan 2004 20:13:00 -0000
@@ -17,7 +17,7 @@
 lib/libgg2_core.so
 lib/libgg2_core.so.2
 lib/pkgconfig/gg2_core.pc
-%%KDE:%%%%LOCALBASE%%share/applnk/Internet/gg2.desktop
+%%KDE:%%%%LOCALBASE%%/share/applnk/Internet/gg2.desktop
 share/gg2/pixmaps/arrow.png
 share/gg2/pixmaps/away.png
 share/gg2/pixmaps/emoticon.gif

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

I am a shrubber. My name is Roger the Shrubber. I arrange, design and
sell shrubberies.
Comment 3 Kirill Ponomarev freebsd_committer freebsd_triage 2004-01-21 21:01:54 UTC 
Hi,

On Wed, Jan 21, 2004 at 09:13:10PM +0100, Pav Lucistnik wrote:
> krion,
> 
> can you retry with this simple patch to pkg-plist?
> 
> diff -a -u -r1.4 pkg-plist
> --- pkg-plist   15 Jan 2004 23:48:06 -0000      1.4
> +++ pkg-plist   21 Jan 2004 20:13:00 -0000
> @@ -17,7 +17,7 @@
>  lib/libgg2_core.so
>  lib/libgg2_core.so.2
>  lib/pkgconfig/gg2_core.pc
> -%%KDE:%%%%LOCALBASE%%share/applnk/Internet/gg2.desktop
> +%%KDE:%%%%LOCALBASE%%/share/applnk/Internet/gg2.desktop
>  share/gg2/pixmaps/arrow.png
>  share/gg2/pixmaps/away.png
>  share/gg2/pixmaps/emoticon.gif


No, this patch is also incorrect, just try it. Let's give the
maintainer opportunity to find the error and fix it.

-Kirill
Comment 4 Piotr Smyrak 2004-01-21 22:41:11 UTC 
Hi,

On Wed, 21 Jan 2004 22:01:54 +0100, Kirill Ponomarew
<krion@FreeBSD.org>  wrote:

> On Wed, Jan 21, 2004 at 09:13:10PM +0100, Pav Lucistnik wrote:
> > krion,
> > 
> > can you retry with this simple patch to pkg-plist?
> > 
> > diff -a -u -r1.4 pkg-plist
> > --- pkg-plist   15 Jan 2004 23:48:06 -0000      1.4
> > +++ pkg-plist   21 Jan 2004 20:13:00 -0000
> > @@ -17,7 +17,7 @@
> >  lib/libgg2_core.so
> >  lib/libgg2_core.so.2
> >  lib/pkgconfig/gg2_core.pc
> > -%%KDE:%%%%LOCALBASE%%share/applnk/Internet/gg2.desktop
> > +%%KDE:%%%%LOCALBASE%%/share/applnk/Internet/gg2.desktop
> >  share/gg2/pixmaps/arrow.png
> >  share/gg2/pixmaps/away.png
> >  share/gg2/pixmaps/emoticon.gif
> 
> No, this patch is also incorrect, just try it. Let's give the
> maintainer opportunity to find the error and fix it.

I am glad I got a chance and could learn something new about the
port system. The attached patch should take care of the issue.
Thanks for being patient with me!

-- 
 Piotr Smyrak
 piotr.smyrak@heron.pl
Comment 5 Piotr Smyrak 2004-01-21 22:58:40 UTC 
Hi,

On Wed, 21 Jan 2004 23:41:11 +0100, Piotr Smyrak
<piotr.smyrak@heron.pl>  wrote:

> On Wed, 21 Jan 2004 22:01:54 +0100, Kirill Ponomarew
> <krion@FreeBSD.org>  wrote:
> 
> > On Wed, Jan 21, 2004 at 09:13:10PM +0100, Pav Lucistnik wrote:
> > > krion,
> > > 
> > > can you retry with this simple patch to pkg-plist?
> > > 
> > > diff -a -u -r1.4 pkg-plist
> > > --- pkg-plist   15 Jan 2004 23:48:06 -0000      1.4
> > > +++ pkg-plist   21 Jan 2004 20:13:00 -0000
> > > @@ -17,7 +17,7 @@
> > >  lib/libgg2_core.so
> > >  lib/libgg2_core.so.2
> > >  lib/pkgconfig/gg2_core.pc
> > > -%%KDE:%%%%LOCALBASE%%share/applnk/Internet/gg2.desktop
> > > +%%KDE:%%%%LOCALBASE%%/share/applnk/Internet/gg2.desktop
> > >  share/gg2/pixmaps/arrow.png
> > >  share/gg2/pixmaps/away.png
> > >  share/gg2/pixmaps/emoticon.gif
> > 
> > No, this patch is also incorrect, just try it. Let's give the
> > maintainer opportunity to find the error and fix it.
> 
> I am glad I got a chance and could learn something new about the
> port system. The attached patch should take care of the issue.
> Thanks for being patient with me!

I should think slower. Sorry. This one is correct.

diff -ru gnugadu2.orig/pkg-plist gnugadu2/pkg-plist
--- gnugadu2.orig/pkg-plist	Wed Jan 21 01:49:00 2004
+++ gnugadu2/pkg-plist	Wed Jan 21 23:48:19 2004
@@ -17,7 +17,6 @@
 lib/libgg2_core.so
 lib/libgg2_core.so.2
 lib/pkgconfig/gg2_core.pc
-%%KDE:%%%%LOCALBASE%%share/applnk/Internet/gg2.desktop
 share/gg2/pixmaps/arrow.png
 share/gg2/pixmaps/away.png
 share/gg2/pixmaps/emoticon.gif
@@ -299,3 +298,5 @@
 @dirrm share/gg2/pixmaps
 @dirrm share/gg2
 @dirrm lib/gg2
+%%KDE:%%@cwd %%LOCALBASE%%
+%%KDE:%%share/applnk/Internet/gg2.desktop

-- 
 Piotr Smyrak
 piotr.smyrak@heron.pl
Comment 6 Kirill Ponomarev freebsd_committer freebsd_triage 2004-01-22 09:20:11 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!