- Update to 1.56 - Take maintainership Generated with FreeBSD Port Tools 0.50
State Changed From-To: open->feedback Build on perl 5.005_03 reports: Warning: prerequisite Test::More 0 not found at (eval 1) line 219 Should Test::Simple be added as a dependencies or are you sure it is only used by make test?
+-le 06/02/2004 14:53 +0100, Lars Thegler écrivait : | Erwin Lansing wrote: |> Should Test::Simple be added as a dependencies or are you sure |> it is only used by make test? | | Yes, Test::More is only used for testing. But I get your point - to silence | the warning, either the dependency should be added, or the Makefile.PL | patched. What's best practice in these cases? As far as I can tell, there are good chances that Test::Simple is already installed, but I would not bring a SOMETHING_DEPENDS if it does not really depends on it. if a developper wants to make test, he's likely to have it already, and if not, he's likely to be smart enough to find out how to add it. All this to say that I don't think adding a dependency just to shut up Makefile.PL is a good thing. -- Mathieu Arnold
On Fri, Feb 06, 2004 at 03:47:04PM +0100, Mathieu Arnold wrote: > +-le 06/02/2004 14:53 +0100, Lars Thegler écrivait : > | Erwin Lansing wrote: > |> Should Test::Simple be added as a dependencies or are you sure > |> it is only used by make test? > | > | Yes, Test::More is only used for testing. But I get your point - to silence > | the warning, either the dependency should be added, or the Makefile.PL > | patched. What's best practice in these cases? > > As far as I can tell, there are good chances that Test::Simple is already > installed, but I would not bring a SOMETHING_DEPENDS if it does not really > depends on it. if a developper wants to make test, he's likely to have it > already, and if not, he's likely to be smart enough to find out how to add it. > All this to say that I don't think adding a dependency just to shut up > Makefile.PL is a good thing. > I replied to Lars personally, but let me repeat it here. I have seen both cases, where the maintainer adds Test::Simple or just leaves the warning. Personally I add the dependency as I assume (most likely wrongly in several cases) that if the author tests for it, it needs it. But I'll leave it up to the maintainers discression to decide. -erwin -- _._ _,-'""`-._ Erwin Lansing (,-.`._,'( |\`-/| erwin@lansing.dk http://droso.org `-.-' \ )-`( , o o) erwin@FreeBSD.org -bf- `- \`_`"'-
State Changed From-To: feedback->closed Committed, tahnks! I decided to go with mat's suggestion and leave the warning while building.