Bug 63545 - Today's portupgrade of linux-flashplugin to linux-flashplugin-6.0r79_1 breaks flash for linux-opera on FreeBSD-4.9Stable
Summary: Today's portupgrade of linux-flashplugin to linux-flashplugin-6.0r79_1 breaks...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-29 19:40 UTC by Stacey Roberts
Modified: 2004-05-14 05:40 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stacey Roberts 2004-02-29 19:40:24 UTC
After fresh cvsup of ports tree today. I portsupgraded linux-flashplugin to version: linux-flashplugin-6.0r79_1. After restarting linux-opera, flash no longer works. The version of linux-flashplugin that I had working successfully was: linux-flashplugin-6.0r79. My version of linux-opera is: linux-opera-7.23.20031119

This is the procedure I did prior to running portupgrade:
1) You will need to tweak the Makefile, which it was designed for Mozilla.
 
# cd /usr/ports/www/linux-flashplugin6
# vi Makefile
 
Change from...
 
 
code:
 
PLUGINSDIR=lib/linux-mozilla/plugins
 
to...
 
 
code:
 
USE_X_PREFIX=yes
PLUGINSDIR=share/opera/plugins
 
Save and exit it.
 
# portupgrade -R linux-flashplugin-6.0r79

This finished successfully.
 
 
2) Close Opera and run it again.

After linux-opera restart, I then browsed to:  http://www.macromedia.com/shockwave/welcome/

Flash animation does not load.

Fix: 

Don't know
How-To-Repeat: 
See above
Comment 1 Brandon D. Valentine 2004-02-29 22:15:34 UTC
On Sun, Feb 29, 2004 at 07:39:21PM +0000, Stacey Roberts wrote:
> After fresh cvsup of ports tree today. I portsupgraded
> linux-flashplugin to version: linux-flashplugin-6.0r79_1. After
> restarting linux-opera, flash no longer works. The version of
> linux-flashplugin that I had working successfully was:
> linux-flashplugin-6.0r79. My version of linux-opera is:
> linux-opera-7.23.20031119

Stacey,

Thank you for exposing a problem in my port Makefile.  It appears I have
run up against a known bug in pmake.  From the BUGS section of make(1):

  For loops are expanded before tests, so a fragment such as:
  
    .for TMACHINE in ${SHARED_ARCHS}
    .if ${TMACHINE} = ${MACHINE}
         ...
    .endif
    .endfor
  
  won't work, and should be rewritten the other way around.

I was making use of this construct in my Makefile and due to some cruft
on the system I tested the port on, I didn't notice that this was
failing.  I will be back shortly with a patch that fixes this.

BTW, there is no need to modify the Makefile everytime you cvsup to use
this with linux-opera.  You can define USE_X_PREFIX and PLUGINSDIR on
the make command line, via portupgrade's -m option or in pkgtools.conf's
MAKE_ARGS section.

HTH,

Brandon D. Valentine
-- 
brandon@dvalentine.com                           http://www.geekpunk.net
Pseudo-Random Googlism:  february is 'for the birds'
Comment 2 Jeremy Messenger 2004-02-29 22:34:26 UTC
Actually, you can't do the define PLUGINSDIR because there's no "?" in it.

PLUGINSDIR?=

Cheers,
Mezz


-- 
bsdforums.org 's moderator, mezz.
Comment 3 Brandon D. Valentine 2004-02-29 22:35:46 UTC
Stacey,

In the meantime you can install the port normally and make symlinks to
/usr/local/lib/linux-flashplugin6/* in /usr/X11R6/share/opera/plugins
and you will be able to use the plugin.  What is happening is that the
symlinks are not getting created properly.  The plugin itself should be
installed.

HTH,

Brandon D. Valentine
-- 
brandon@dvalentine.com                           http://www.geekpunk.net
Pseudo-Random Googlism:  brandon is unique with two village greens
Comment 4 Brandon D. Valentine 2004-02-29 22:50:54 UTC
On Sun, Feb 29, 2004 at 04:34:26PM -0600, Jeremy Messenger wrote:
> Actually, you can't do the define PLUGINSDIR because there's no "?" in it.
> 
> PLUGINSDIR?=

Hmm, you're right.  I will include that change in the patch I am working
on.

The problem I'm running into is I don't seem to get variable expansion
to work inside my conditional.

This works:

.for f in ${LIBFILES}
    @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
.if exists(/usr/local/lib/linux-mozilla/plugins)
	echo "Hi! I'm inside the if statement!"
    @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
${PREFIX}/${PLUGINSDIR}
.endif
.endfor

This doesn't:

.for f in ${LIBFILES}
    @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
.if exists(${PREFIX}/${PLUGINSDIR})
	echo "Hi! I'm inside the if statement!"
    @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
${PREFIX}/${PLUGINSDIR}
.endif
.endfor

And I'm not sure why it doesn't work.  At any rate, I have a solution
and with a bit more testing I'll submit a new patch.

Sorry for the inconvenience,

Brandon D. Valentine
-- 
brandon@dvalentine.com                           http://www.geekpunk.net
Pseudo-Random Googlism:  tejas is mccarley's way of continuing his
                         family's texas traditions
Comment 5 Brandon D. Valentine 2004-02-29 23:08:49 UTC
On Sun, Feb 29, 2004 at 04:15:34PM -0600, Brandon D. Valentine wrote:
> It appears I have run up against a known bug in pmake.  From the BUGS
> section of make(1):

Hmm.  This is not it, this is not it at all.  To be honest I'm very
confused by the behavior I am seeing out of make.

It refuses to expand variables inside exists statements at all.

I have just put this in my port Makefile with the declarations, not
inside of a target:

.if exists(${PREFIX}/lib/linux-mozilla/plugins)
PLUGINSDIR?=    ${PREFIX}/lib/linux-mozilla/plugins
.elif exists(${X11BASE}/lib/linux-opera/plugins)
PLUGINSDIR?=    ${PREFIX}/lib/linux-mozilla/plugins
.endif

If I execute 'make -VPLUGINSDIR' I get nothing.

If I change it to read like this:

.if exists(/usr/local/lib/linux-mozilla/plugins)
PLUGINSDIR?=    ${PREFIX}/lib/linux-mozilla/plugins
.elif exists(${X11BASE}/lib/linux-opera/plugins)
PLUGINSDIR?=    ${PREFIX}/lib/linux-mozilla/plugins
.endif

Then 'make -VPLUGINSDIR' spits out:
/usr/local/lib/linux-mozilla/plugins

Anybody out there reading know why make would fail to expand PREFIX
there?

Thanks,

Brandon D. Valentine
-- 
brandon@dvalentine.com                           http://www.geekpunk.net
Pseudo-Random Googlism:  winter is here with his grouch
Comment 6 Jeremy Messenger 2004-02-29 23:08:55 UTC
On Sun, 29 Feb 2004 16:50:54 -0600, Brandon D. Valentine 
<ports@brandon.dvalentine.com> wrote:

> On Sun, Feb 29, 2004 at 04:34:26PM -0600, Jeremy Messenger wrote:
>> Actually, you can't do the define PLUGINSDIR because there's no "?" in 
>> it.
>>
>> PLUGINSDIR?=
>
> Hmm, you're right.  I will include that change in the patch I am working
> on.
>
> The problem I'm running into is I don't seem to get variable expansion
> to work inside my conditional.
>
> This works:
>
> .for f in ${LIBFILES}
>     @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
> .if exists(/usr/local/lib/linux-mozilla/plugins)
> 	echo "Hi! I'm inside the if statement!"
>     @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
> ${PREFIX}/${PLUGINSDIR}
> .endif
> .endfor
>
> This doesn't:
>
> .for f in ${LIBFILES}
>     @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
> .if exists(${PREFIX}/${PLUGINSDIR})
> 	echo "Hi! I'm inside the if statement!"
>     @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
> ${PREFIX}/${PLUGINSDIR}
> .endif
> .endfor
>
> And I'm not sure why it doesn't work.  At any rate, I have a solution
> and with a bit more testing I'll submit a new patch.

Yeah, that puzzled me.. I tried to add the quote and others; it still 
doesn't work. Maybe, it's a bug or just a missing feature.

Cheers,
Mezz

> Sorry for the inconvenience,
>
> Brandon D. Valentine


-- 
bsdforums.org 's moderator, mezz.
Comment 7 Stacey Roberts 2004-03-01 20:38:35 UTC
Hi Brandon,
   Thanks for getting back to me on this matter.

----- Original Message -----
From: ""Brandon D. Valentine" <ports@brandon.dvalentine.com>"
To: To Stacey Roberts
Date: Sun, 29 Feb, 2004 22:35 GMT
Subject: Re: ports/63545: linux-flashplugin6 bug

> Stacey,
> 
> In the meantime you can install the port normally and make symlinks to
> /usr/local/lib/linux-flashplugin6/* in /usr/X11R6/share/opera/plugins
> and you will be able to use the plugin.  What is happening is that the
> symlinks are not getting created properly.  The plugin itself should be
> installed.
> 



Err.., When I check /usr/local/lib, I get:
/usr/local/lib $ ls -la linux-*
ls: linux-*: No such file or directory
/usr/local/lib $

Exactly what is it that I'm supposed to have in this dir anyways? There aren't any references to any file nor dir that's opera, or linux prefixed.

Thanks again.

Hope to hear from you on this again soon.

Regards,

Stacey

> HTH,
> 
> Brandon D. Valentine
> -- 
> brandon@dvalentine.com                           http://www.geekpunk.net
> Pseudo-Random Googlism:  brandon is unique with two village greens


-- 
Stacey Roberts
B. Sc (HONS) Computer Science

Web: www.vickiandstacey.com
Comment 8 Brandon D. Valentine 2004-03-01 20:51:01 UTC
On Mon, Mar 01, 2004 at 08:38:35PM +0000, Stacey Roberts wrote:
> 
> Err.., When I check /usr/local/lib, I get:
> /usr/local/lib $ ls -la linux-*
> ls: linux-*: No such file or directory
> /usr/local/lib $
> 
> Exactly what is it that I'm supposed to have in this dir anyways? There aren't any references to any file nor dir that's opera, or linux prefixed.

Stacey, if you've installed your patched version of the port than the
plugin is probably in /usr/X11R6/lib/linux-flashplugin6.  You set
USE_X_PREFIX.

HTH,

Brandon D. Valentine
-- 
brandon@dvalentine.com                           http://www.geekpunk.net
Pseudo-Random Googlism:  valentine is in very nice condition
Comment 9 Stacey Roberts 2004-03-04 18:31:04 UTC
Hello,

----- Original Message -----
From: ""Brandon D. Valentine" <ports@brandon.dvalentine.com>"
To: To Stacey Roberts
Date: Mon, 01 Mar, 2004 20:51 GMT
Subject: Re: ports/63545: linux-flashplugin6 bug

> On Mon, Mar 01, 2004 at 08:38:35PM +0000, Stacey Roberts wrote:
> > 
> > Err.., When I check /usr/local/lib, I get:
> > /usr/local/lib $ ls -la linux-*
> > ls: linux-*: No such file or directory
> > /usr/local/lib $
> > 
> > Exactly what is it that I'm supposed to have in this dir anyways? There aren't any references to any file nor dir that's opera, or linux prefixed.
> 
> Stacey, if you've installed your patched version of the port than the
> plugin is probably in /usr/X11R6/lib/linux-flashplugin6.  You set
> USE_X_PREFIX.
> 
> HTH,


Is there someone working on a fix for this problem at the moment? 

Regards,

Stacey

> 
> Brandon D. Valentine
> -- 
> brandon@dvalentine.com                           http://www.geekpunk.net
> Pseudo-Random Googlism:  valentine is in very nice condition


-- 
Stacey Roberts
B. Sc (HONS) Computer Science

Web: www.vickiandstacey.com
Comment 10 Stacey Roberts 2004-04-03 13:19:57 UTC
Hello,
     Is a fix for this bug being worked on.

I ask given today's heads up concerning the upcoming ports freeze for FreeBSD-4.10-Rel

Regards,

Stacey
-- 
Stacey Roberts
Comment 11 Brandon D. Valentine 2004-04-03 20:15:59 UTC
On Sat, Apr 03, 2004 at 01:19:57PM +0100, Stacey Roberts wrote:
> Hello,
>      Is a fix for this bug being worked on.
> 
> I ask given today's heads up concerning the upcoming ports freeze for FreeBSD-4.10-Rel

Thanks for the concern, Stacey.  I will take care of this sometime in
the next week and well ahead of the ports freeze.  I have been ill for
several weeks now, and won't get into the personal details of that, but
it has kept me from paying much attention at all to FreeBSD.

Thanks,

Brandon D. Valentine
-- 
brandon@dvalentine.com                           http://www.geekpunk.net
Pseudo-Random Googlism:  rain is not my indian name new york
Comment 12 Stacey Roberts 2004-04-03 21:01:57 UTC
Hi Brandon,
   Thanks for the reply.

----- Original Message -----
From: ""Brandon D. Valentine" <ports@brandon.dvalentine.com>"
To: To Stacey Roberts
Date: Sat, 03 Apr, 2004 20:15 BST
Subject: Re: ports/63545: linux-flashplugin6 bug

> On Sat, Apr 03, 2004 at 01:19:57PM +0100, Stacey Roberts wrote:
> > Hello,
> >      Is a fix for this bug being worked on.
> > 
> > I ask given today's heads up concerning the upcoming ports freeze for FreeBSD-4.10-Rel
> 
> Thanks for the concern, Stacey.  I will take care of this sometime in
> the next week and well ahead of the ports freeze.  I have been ill for
> several weeks now, and won't get into the personal details of that, but
> it has kept me from paying much attention at all to FreeBSD.


No worries, Brandon. I didn't know you were ill - but I did feel it necessary to "nudge", given the upcoming freeze, hope you didn't mind too much.

Looking forward to hearing of a fix as and when you are able. Take care.

Regards,

Stacey

> 
> Thanks,
> 
> Brandon D. Valentine
> -- 
> brandon@dvalentine.com                           http://www.geekpunk.net
> Pseudo-Random Googlism:  rain is not my indian name new york


-- 
Stacey Roberts
B. Sc (HONS) Computer Science

Web: www.vickiandstacey.com
Comment 13 Jeremy Messenger 2004-05-14 04:09:20 UTC
Hello guys,

May I close this PR? It's a good news for all of us! ;-) Now, the new 
version of linux-opera has the ability of find flash by itself without 
have to put in its own plugin folder. It finally work with flash plugin, 
so it should give you (Brandon) the less headache for not need to hack on 
your linux-flashplugin6 port.

I will be able to commit the update of linux-opera by tonight or tomorrow 
when my mentor, adamw, gives me the approve.

Cheers,
Mezz


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
bsdforums.org 's moderator, mezz.
Comment 14 Jeremy Messenger freebsd_committer freebsd_triage 2004-05-14 05:38:56 UTC
State Changed
From-To: open->closed

This is fixed in the update of linux-opera (7.50.20040511).