Bug 63551 - Lack of DTD in cgi scripts
Summary: Lack of DTD in cgi scripts
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ceri Davies
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-29 21:10 UTC by Vladimir Tchoukharev
Modified: 2006-09-24 22:46 UTC (History)
0 users

See Also:


Attachments
cgi-style.patch (513 bytes, patch)
2004-03-07 13:12 UTC, Vladimir Tchoukharev
no flags Details | Diff
cgi1.patch (3.45 KB, patch)
2004-03-07 18:02 UTC, Vladimir Tchoukharev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Tchoukharev 2004-02-29 21:10:01 UTC
Webpages produced by CGI scripts on www.freebsd.org do not have any DTD declaration nor
character encoding. This is due to lack of the features in cgi-lib.pl, used by all
the scripts.
I do not use cgi-lib.pl, thus I am not sure how to fix it.

How-To-Repeat: 
Try any script from www.freebsd.org/cgi/, e.g.
http://validator.w3.org/check?uri=http://www.freebsd.org/cgi/query-pr.cgi

Best regards,
V.Chukharev
Comment 1 Vladimir Tchoukharev 2004-03-07 13:12:42 UTC
The attached patch, applied in /usr/www/en/cgi/ makes the pages,
generated by cgi scripts valid HTML 4.01 Transitional

Best regards,
V. Chukharev
Comment 2 Vladimir Tchoukharev 2004-03-07 18:02:00 UTC
Attached is a new patch, which includes the previous one (sorry for that).

With this patch the of parameter separator in URI '&' should become
interchangeable with ';', so that both should work.
The change is made in one script only, namely query-pr-summary.cgi

Please review and check. I have no possibility for extensive tests
at the moment (no GNATS and no time as always:).

Are the changes OK to continue?

Best regards,
V.Chukharev
Comment 3 Vladimir Tchoukharev 2004-04-25 19:48:51 UTC
Can anybody look at this, please? I really believe it
can be commited. Well, at least the first two line patch.

Best regards,
-- 
V.Chukharev
Comment 4 Ceri Davies freebsd_committer freebsd_triage 2004-09-24 16:25:48 UTC
Responsible Changed
From-To: freebsd-www->ceri

I'm doing some work around here.
Comment 5 Vladimir Chukharev 2005-08-26 09:15:01 UTC
What are problems with commiting this? At least the minimal part?
Can I help with additional explanations/references/whatever?

Bestregards,
-- 
V.Chukharev
Comment 6 Daniel Gerzo freebsd_committer freebsd_triage 2006-09-16 23:04:34 UTC
Hello bug-followup,

  I would say, we can close this PR as we have most of this in
  cgi-style.pl and query-pr.cgi and query-pr-summary.cgi are already
  valid xhtml.

-- 
Best regards,
 Daniel                          mailto:danger@FreeBSD.org
Comment 7 V.Chukharev 2006-09-17 11:48:41 UTC
I agree that this PR can be closed.

Side notes.

I keep my opinion that a semicolon ';' is a cleaner parameter separator
than an ampersand '&'. It is the recomended by w3c separator, too.

Currently the separator is used in front of the first parameter like in
/cgi/query-pr-summary.cgi?&sort=3Dlastmod , this is not needed.

V.Chukharev, PR originator
Comment 8 Daniel Gerzo freebsd_committer freebsd_triage 2006-09-24 22:44:49 UTC
State Changed
From-To: open->closed

Close this PR as it is no more accurate. 
Anyway, thank you for your interest!