Bug 68256 - bsd.gnome.mk locale patch is incomplete
Summary: bsd.gnome.mk locale patch is incomplete
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-23 23:40 UTC by Jean-Yves Lefort
Modified: 2004-06-27 18:33 UTC (History)
0 users

See Also:


Attachments
file.diff (675 bytes, patch)
2004-06-23 23:40 UTC, Jean-Yves Lefort
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Lefort 2004-06-23 23:40:17 UTC
The gnomehack component of bsd.gnome.mk fixes the locale path in the
Makefile.in files.

However, for most programs the locale path also needs to be patched in
the configure scripts, since it's the place from where the path is
hardwired into the program.

Failing to do so results in a program trying to find its translations
in the wrong location, and the problem is likely to stay unnoticed.

The attached patch fixes the issue.

WARNING: some ports already fix that themselves by the mean of a
configure patch. These ports will break if this patch is committed,
therefore I suggest to mail the maintainers of all the ports using
USE_GNOME=gnomehack and having a configure patch, asking them to fix
their port(s).
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-06-23 23:43:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer(s).
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2004-06-24 02:14:07 UTC
State Changed
From-To: open->feedback

Can you produce a list of ports that will be broken with this patch?  That 
will make contacting the maintainers easier.  Thanks.
Comment 3 Jean-Yves Lefort 2004-06-24 18:40:20 UTC
I did a "make patch" on all the ports using gnomehack and having a
configure patch. It failed for the following ports:

audio/beast
audio/streamtuner
databases/gnomedb
net/gnomba
sysutils/gnomecontrolcenter2

Since the number of ports is low and the fixes are trivial, I suggest
you just fix them and apply the bsd.gnome.mk patch.
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2004-06-27 18:33:06 UTC
State Changed
From-To: feedback->closed

Committed, thanks!