Bug 74986 - [patch] sysctlize a parameter of if_em's interrupt moderation
Summary: [patch] sysctlize a parameter of if_em's interrupt moderation
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 5.3-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords: IntelNetworking, patch
Depends on:
Blocks:
 
Reported: 2004-12-12 14:30 UTC by Shusuke SHINOMIYA
Modified: 2023-02-09 07:08 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shusuke SHINOMIYA 2004-12-12 14:30:26 UTC 
This change sysctlize last one of the parameter of if_em's interrupt
moderation .

sysctl hw.em?.int_throttle_ceil corresponds to the `absolute timer' at
AP450(*1), application note by intel.
*1 ftp://download.intel.com/design/network/applnots/ap450.pdf

`absolute timer' is for suppressing rate of interrupt per unit of time.
The value of int_throttle_ceil means a ceiling of the number of interrupt
fireing per unit of time.

Default value of int_throttle_ceil is 8000. Setting int_throttle_ceil 0
means disabling throttle moderation concerning the absolute timer.

Fix: 

The diff of URL shown below adds sysctl int_throttle_ceil to hw.em?.

http://www.fornext.org/patch/if_em.diff
Comment 1 Xin LI freebsd_committer freebsd_triage 2004-12-12 15:31:30 UTC 
Responsible Changed
From-To: freebsd-bugs->tackerman

Over to our Mr. em(4)
Comment 2 Shusuke SHINOMIYA 2004-12-14 02:00:36 UTC 
 I'm sorry, there was a mistake in the description of int_throttle_ceil.
 int_throttle_ceil corresponds to the `throttle timer' at chapter 3.4 in
 AP450.

-- 
Shunsuke SHINOMIYA <shino@fornext.org>
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2006-04-05 01:38:03 UTC 
State Changed
From-To: open->feedback

Did this change ever get incorporated?
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2006-04-05 01:38:03 UTC 
Responsible Changed
From-To: tackerman->linimon

Reset PR assigned to inactive committer. 

Hat:	gnats-admin
Comment 5 Mark Linimon 2006-04-05 15:31:44 UTC 
----- Forwarded message from Shunsuke SHINOMIYA <shino@fornext.org> -----

From: Shunsuke SHINOMIYA <shino@fornext.org>
To: Mark Linimon <linimon@FreeBSD.org>

 Thank you for your noticing.
 This patch has not been taken yet.

 And, I modified the patch for RELENG_6.
http://www.fornext.org/patch/if_em_6.diff

 This function is useful for suppressing bursty traffic given by
Interrupt Moderation.

 Thanks in advance.

-- 
Shunsuke SHINOMIYA <shino@fornext.org>

----- End forwarded message -----
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2006-04-05 20:59:41 UTC 
State Changed
From-To: feedback->suspended

The patch has not yet been incorporated.  Mark 'suspended' awaiting an 
interested committer to evaluate.
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2006-04-05 20:59:41 UTC 
Responsible Changed
From-To: linimon->freebsd-bugs
Comment 8 Gleb Smirnoff freebsd_committer freebsd_triage 2006-04-07 10:14:32 UTC 
Responsible Changed
From-To: freebsd-bugs->glebius

I will look at this.
Comment 9 Gleb Smirnoff freebsd_committer freebsd_triage 2007-03-28 15:06:36 UTC 
Responsible Changed
From-To: glebius->jfv

Cleaning old PRs assigned to myself... Assign this one to the em(4) maintainer.
Comment 10 Mark Linimon freebsd_committer freebsd_triage 2015-11-12 07:42:17 UTC 
Reassign to erj@ for triage.  To submitter: is this issue still relevant?
Comment 11 Eitan Adler freebsd_committer freebsd_triage 2018-05-28 19:45:21 UTC 
batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.
Comment 12 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:34:36 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 13 Kevin Bowling freebsd_committer freebsd_triage 2023-02-09 07:08:57 UTC 
This is configured in supported versions via the sysctl:
dev.em.0.itr: interrupt delay limit in usecs/4