Due to the way the ignore message is output by bsd.port.mk, quoted IGNORE messages containing unquoted shell characters may cause the command to fail. The IGNORE message is not printed and the user is left with a cryptic error message. The following ports are affected: graphics/kix-kmod palm/uppc-kmod print/trueprint x11/nvidia-driver Maintainers are cc'ed. Fix: The IGNORE message should not be wrapped in "". If you don't believe me, take a look at IGNORECMD in bsd.port.mk. If IGNORE is quoted in "", the quoting in IGNORECMD ends up all wrong. Patch below removes "" quotes. How-To-Repeat: "make" any of the abovementioned ports under IGNOREable conditions.
Bugger, I left 3 lines in uppc-kmod that I didn't mean to (the "test" target). Committer, pretty please tweak them out for me. Cheers. -- Sam Lawrance ph +61 0425 228 579 freenode: deft
Forwarded message -------- Original Message -------- Subject: Re: [patch] Unquoted shell characters in IGNORE messages causing port error Date: Tue, 11 Jan 2005 12:58:39 -0000 (GMT) From: Jonathan Belson <jon@witchspace.com> To: Sam Lawrance <boris@brooknet.com.au> CC: freebsd-gnats-submit@freebsd.org References: <20050111114328.A7A094D2@localhost> Hiya The kix-kmod change looks fine to me; feel free to apply the patch. Cheers, --Jon http://www.witchspace.com
State Changed From-To: open->closed Fixed, thanks! I just committed the two last changes.