FreeBSD Bugzilla – Bug 76258
games/scummvm: WITH_MPEG2 needs WITH_VORBIS to compile
Last modified: 2005-04-14 14:57:58 UTC
As of 0.7.0, games/scummvm cannot be compiled with MPEG2 support if Vorbis support is not enabled as well. The problem is the file sword1/animation.cpp. When WITH_MPEG2 is set, in line 121 of this file, makeVorbisStream is called unconditionally. Unfortunately, this is a Vorbis library function and is not defined if WITH_VORBIS is not set as well.
is called no matter wheter USE_VORBIS is set or not.
The simplest fix would be to make WITH_MPEG2 depend on WITH_VORBIS.
Another way of fixing this would be to change the source code, but from looking at the code it seems that the Vorbis support is necessary for the relevant code section to perform its intended job.
How-To-Repeat: [make sure to remove /var/db/ports/scummvm/options]
[wait for compiler error]
Dear maintainer, please look into this issue!
Forwarded PR to maintainer
* Volker Stolz <firstname.lastname@example.org> [2005-01-21 16:27:30 +0100]:
> Dear maintainer, please look into this issue!
I'll take a look this weekend. Thank you for alerting me.
C +44 (0)7966 203990
The following patch forces vorbis if mpeg2 is defined. With a maintainer address update and bumped revision (perhaps unnecessary)
--- scummvm-orig/Makefile Mon Jan 10 00:17:44 2005
+++ scummvm/Makefile Mon Jan 24 02:29:47 2005
@@ -7,11 +7,12 @@
CATEGORIES= games emulators
COMMENT= Graphical Adventure Game Virtual Machine
@@ -32,6 +33,10 @@
DOCS= NEWS README TODO
Hm, this doesn't seem to work. Try setting MPEG2 with 'make config',
then make -V WITH_VORBIS: It remains unset.
Note: When playing with OPTIONS, nothing is set before
bsd.port.pre.mk inclusion, since it does process your OPTIONS.