Bug 76611 - [i4b] [patch] i4b itjc bad enums for PIB cycle time
Summary: [i4b] [patch] i4b itjc bad enums for PIB cycle time
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 6.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-isdn (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-23 23:10 UTC by Mauritz Sundell
Modified: 2006-05-13 15:40 UTC (History)
0 users

See Also:

Attachments
itjc.diff (1.14 KB, patch)
2005-05-17 01:19 UTC, prallon 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mauritz Sundell 2005-01-23 23:10:25 UTC 
I think that in src/sys/i4b/layer1/itjc/i4b_itjc_pci.c:
TIGER_PIB_5_CYCLES should be 0x10 (not 0x01)
TIGER_PIB_12_CYCLES should be 0x20 (not 0x10)

Maybe also TIGER_PIB_5_CYCLES should be named TIGER_PIB_8_CYCLES
and TIGER_PIB_12_CYCLES should be named TIGER_PIB_15_CYCLES

The later I'm not sure but atleast accordning to the Tiger320 data sheet rev. 1.2 it should be so.

Fix: 

See description
How-To-Repeat: I haven't compiled and used the code, I was only reading it for rewriting zaptel-driver for another TigerJet-based card.
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2005-05-10 14:23:00 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-isdn

Over to ISDN Mailinglist
Comment 2 prallon 2005-05-17 01:19:42 UTC 
Hi,

Thank you for noticing the typo. While fixing it, I found another couple.
Attached is the diff with the fixes.

[]'s

--
Prallon
Comment 3 hm freebsd_committer freebsd_triage 2006-05-13 15:40:12 UTC 
State Changed
From-To: open->closed

diff committed to current.