Bug 77530 - Makefile problem with postgresql 7.4 on FreeBSD 5.1
Summary: Makefile problem with postgresql 7.4 on FreeBSD 5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Palle Girgensohn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-14 21:30 UTC by Manfred Riem
Modified: 2005-02-19 12:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manfred Riem 2005-02-14 21:30:22 UTC
When trying to build /usr/ports/database/postgresql74-client it
bombs out with an error on line 74, stating a Malformed conditional

How-To-Repeat: Build the /usr/ports/database/postgresql74-client
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2005-02-15 09:18:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->girgen

Over to maintainer (looks like you might be bitten by a 'make'-bug, 
I wouldn't recommend running 5.1 anyway)
Comment 2 Palle Girgensohn 2005-02-15 11:16:49 UTC
Hi!

Is that line 74 in the databases/postgresql74-server/Makefile?

i.e.:

.  if (${OSVERSION} < 500041) && !exists(${LOCALBASE}/include/getopt.h)


I can't possibly see how that can be a bad conditional. Is your ports tree 
up to date?

Could you please send me the output of ``make -d A'', I'll see if I can 
spot something.

/Palle

PS. As vs@ wrote, I wouldn't recommend 5.1. DS.
Comment 3 Manfred Riem 2005-02-16 03:11:27 UTC
Hi Palle,

> Is that line 74 in the databases/postgresql74-server/Makefile?
>
> i.e.:
> 
> .  if (${OSVERSION} < 500041) && 
> !exists(${LOCALBASE}/include/getopt.h)

Correct

> I can't possibly see how that can be a bad conditional. Is 
> your ports tree up to date?
> 

Entire ports tree was updated just an hour before I tried
to compile it.

> Could you please send me the output of ``make -d A'', I'll 
> see if I can spot something.

Hereby the requested output, see the attachment ;)

> PS. As vs@ wrote, I wouldn't recommend 5.1. DS.

I know I am installing it right now because I need to simulate
a system upgrade from 5.1 to 5.3. And this hit me ;).

Kind regards,
Manfred Riem
mriem@manorrock.org
http://www.manorrock.org/ 
Comment 4 blackraven 2005-02-17 10:24:16 UTC
Hello !

I have received the same error when tried to build postgresql74-server 
on FreeBSD-4.7 .

> > Is that line 74 in the databases/postgresql74-server/Makefile?
> > i.e.:
> > . if (${OSVERSION} < 500041) &&
> > !exists(${LOCALBASE}/include/getopt.h)
>
> Correct

I change the line 74 from
.  if (${OSVERSION} < 500041) && !exists(${LOCALBASE}/include/getopt.h)
to
.  if (${OSVERSION} < 500041 ) && !exists(${LOCALBASE}/include/getopt.h)
and all has builded without errors.


-- 
With Best Regards , Alexandr.
[http://www.raven77.narod.ru] [ICQ#126686757] [RLU# 275952]
Comment 5 Palle Girgensohn 2005-02-17 10:52:53 UTC
>
>  I change the line 74 from
>  .  if (${OSVERSION} < 500041) && !exists(${LOCALBASE}/include/getopt.h)
>  to
>  .  if (${OSVERSION} < 500041 ) && !exists(${LOCALBASE}/include/getopt.h)
>  and all has builded without errors.

If that's so, it is indeed a make bug. Manfred, could you please try this 
as well, perhaps it will help?

/Palle
Comment 6 Manfred Riem 2005-02-17 15:02:29 UTC
Hi Palle,

Yup that fixes the problem. Thanks! So I hit a make bug.
Yuck ;). Anyway, maybe you still want to commit it like
this. Some other folks might hit it as well.

Kind regards,
Manfred Riem
mriem@manorrock.org
http://www.manorrock.org/

> -----Original Message-----
> From: Palle Girgensohn [mailto:girgen@pingpong.net] 
> Sent: Thursday, February 17, 2005 3:53 AM
> To: freebsd-gnats-submit@FreeBSD.org; mriem@manorrock.org
> Cc: Alexandr Davidenko
> Subject: Re: ports/77530: Makefile problem with postgresql 
> 7.4 on FreeBSD 5.1
> 
> >
> >  I change the line 74 from
> >  .  if (${OSVERSION} < 500041) && 
> > !exists(${LOCALBASE}/include/getopt.h)
> >  to
> >  .  if (${OSVERSION} < 500041 ) && 
> > !exists(${LOCALBASE}/include/getopt.h)
> >  and all has builded without errors.
> 
> If that's so, it is indeed a make bug. Manfred, could you 
> please try this as well, perhaps it will help?
> 
> /Palle
> 
>
Comment 7 Palle Girgensohn freebsd_committer freebsd_triage 2005-02-19 12:09:32 UTC
State Changed
From-To: open->closed

Committed. Thanks!