Bug 78687 - Warning cleanups for graphics/URT port
Summary: Warning cleanups for graphics/URT port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Simon Barner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-11 06:00 UTC by giffunip
Modified: 2005-03-13 17:12 UTC (History)
0 users

See Also:


Attachments
file.diff (16.10 KB, patch)
2005-03-11 06:00 UTC, giffunip
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description giffunip 2005-03-11 06:00:16 UTC
      The Utah Raster Toolkit is a classic (like in old) application. The BRLCAD people include URT in their package and Lee Butler has made some cleanups in order to improve the build on IRIX. I have taken his patches and have done a few more cleanups. For now this is just a cleanup: it make it easier for me to follow the BRLCAD changes, in other words, there's no need to bump the port version yet.

Fix: Patch follows:
How-To-Repeat:       I should mention..I have patches to build support for the BRLCAD framebuffer but I prefer to wait until BRCAD can be built without OpenGL.
Comment 1 Simon Barner freebsd_committer 2005-03-11 12:05:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->barner

Grab.
Comment 2 Simon Barner freebsd_committer 2005-03-11 18:13:45 UTC
[Cc'ed freebsd-ports, further discussion should happen there]

Hello Pedro, others,

IMHO these kinds of patches do not belong into the ports collection in
the first place. While they are correct, and reduce the number of
compiler warnings and improve the general quality of the code, they are
not necessary to make the software run on FreeBSD.

Is there any chance to have those changes integrated upstream, i.e. by
the authors of URT?

If that's not the case (because the software is abandoned), or the do
not plan a new release within a reasonable timeframe, I'd prefer to have
those patches bundled in one file, say patch-FIX-WARNINGS, so that our
repository is not clobbered with a dozend of small, non-FreeBSD specific
patches.

So, to sum this up: I really appreciate your work very much, but IMO the
ports collection is not the best place to store your patches.

Perhaps someone else from the ports@ list can share her/his opinion with
us?

Simon
Comment 3 Simon Barner freebsd_committer 2005-03-13 17:11:20 UTC
State Changed
From-To: open->closed

Patches committed, thank you very much for your submission!