Bug 79091 - [i386] [patch] Small optimization for i386/support.s
Summary: [i386] [patch] Small optimization for i386/support.s
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: i386 (show other bugs)
Version: 5.3-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-i386 mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-21 15:40 UTC by Andrey Simonenko
Modified: 2017-12-31 22:32 UTC (History)
0 users

See Also:


Attachments
file.diff (865 bytes, patch)
2005-03-21 15:40 UTC, Andrey Simonenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Simonenko 2005-03-21 15:40:02 UTC
suword(), suword16(), subyte() and copyinstr() from i386/support.s
restore "trashed" register %ecx, but this register is not really
trashed in case of non I386_CPU in su*() functions and in copyinstr().

The same situation with the same functions in amd64/support.S.

And the same situation with 4.x, 5.x and HEAD.
Comment 1 Remko Lodder freebsd_committer 2010-07-14 08:06:16 UTC
State Changed
From-To: open->feedback

Hello, the code in question is using 'rcx' now instead of 'ecx'to restore 
the registers. That might have solved your problem can you please have a look at that please and confirm whether it's still relevant?
Comment 2 b. f. 2011-05-31 19:44:42 UTC
Feedback for this PR was received on the freebsd-i386 mailing list,
but was not recorded here:

http://lists.freebsd.org/pipermail/freebsd-i386/2010-July/008712.html

b.
Comment 3 Brendan Fabeny freebsd_committer 2011-06-22 14:59:43 UTC
State Changed
From-To: feedback->open

Feedback has been received
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:54 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped