Bug 83999 - [firewire] [patch] panic in fw_bus_explore due to NULL reference
Summary: [firewire] [patch] panic in fw_bus_explore due to NULL reference
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-firewire (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-24 14:40 UTC by Markus Wild
Modified: 2005-12-04 02:32 UTC (History)
0 users

See Also:

Attachments
file.diff (720 bytes, patch)
2005-07-24 14:40 UTC, Markus Wild 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Wild 2005-07-24 14:40:23 UTC 
Machine panics at

fw_bus_explore+0x3f: testb $0x40,0x(%rax)

with %rax being NULL. 

The problem is the line (1339):
       if (!fw_find_self_id(fc, fc->ongonode)->p0.link_active) {

fw_find_self_id() can return 0 if it doesn't find the node. This  is
not taken into account with the above test.

How-To-Repeat: On this machine it was sufficient to load the firewire module to
trigger the panic. A canopus ADV module was plugged into the 
firewire port.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2005-10-25 03:37:39 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-firewire

Over to maintainer(s).
Comment 2 caiquanqing 2005-11-25 03:23:56 UTC 
Can somebody please have a look at this and apply the patch? However,
I can't re-produce this bug, but the fix does not hurt anything. I
made the changement on my two machines according the patch, and
everything looks and works good. One of machine is 7.0-CURRENT,
another one is 6-STABLE.

BR
Cai, Quanqing
Comment 3 simokawa freebsd_committer freebsd_triage 2005-11-25 14:30:03 UTC 
State Changed
From-To: open->feedback

Committed, thanks.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2005-12-04 02:31:55 UTC 
State Changed
From-To: feedback->closed

Fix was committed Nov. 25th.