Bug 84271 - [patch] compress(1) doesn't warn about nasty link handling
Summary: [patch] compress(1) doesn't warn about nasty link handling
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2005-07-29 05:30 UTC by Gary W. Swearingen
Modified: 2021-03-04 13:58 UTC (History)
2 users (show)

See Also:


Attachments
file.diff (665 bytes, patch)
2005-07-29 05:30 UTC, Gary W. Swearingen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gary W. Swearingen 2005-07-29 05:30:26 UTC
See synopsis.

Fix: Apply patch with new paragraph at end of DESCRIPTION
and a new BUGS section:
How-To-Repeat: n/a
Comment 1 Ceri Davies 2005-07-31 14:29:38 UTC
On 29 Jul 2005, at 05:22, Gary W. Swearingen wrote:
> Apply patch with new paragraph at end of DESCRIPTION
> and a new BUGS section:
>
> --- /pr/work/compress..orig.1    Thu Jul 28 21:01:24 2005
> +++ /pr/work/compress.1    Thu Jul 28 21:19:35 2005
> @@ -152,6 +152,16 @@
>  coding (as used in the historical command pack), or adaptive Huffman
>  coding (as used in the historical command compact), and takes less
>  time to compute.
> +.Pp
> +If
> +.Ar file
> +is a soft or hard link
> +.Nm compress
> +will replace it with a compressed copy of the linked-to file,
> +leaving that file uncompressed.
> +If
> +.Ar file
> +is hard linked, it will
>  .Sh DIAGNOSTICS
>  .Ex -std compress uncompress
>  .Pp

This patch looks like it adds half of a sentence?
i.e:

   If file is hard linked, it will

Ceri
-- 
Only two things are infinite, the universe and human stupidity, and I'm
not sure about the former.                        -- Einstein (attrib.)
Comment 2 Gary W. Swearingen 2005-07-31 16:52:20 UTC
Ceri Davies <ceri@submonkey.net> writes:

> This patch looks like it adds half of a sentence?

I didn't delete enough and apparently didn't review it with
my "manfile" command as I normally do.  Sorry.


--- compress..orig.1	Thu Jul 28 21:01:24 2005
+++ compress.1	Sun Jul 31 08:32:13 2005
@@ -152,6 +152,13 @@
 coding (as used in the historical command pack), or adaptive Huffman
 coding (as used in the historical command compact), and takes less
 time to compute.
+.Pp
+If
+.Ar file
+is a soft or hard link
+.Nm compress
+will replace it with a compressed copy of the linked-to file,
+leaving that file uncompressed.
 .Sh DIAGNOSTICS
 .Ex -std compress uncompress
 .Pp
@@ -188,3 +195,5 @@
 .Nm
 command appeared in
 .Bx 4.3 .
+.Sh BUGS
+The program does not handle links well and has no link-handling options.
Comment 3 Ceri Davies freebsd_committer freebsd_triage 2005-08-01 23:15:49 UTC
Responsible Changed
From-To: freebsd-doc->ceri

Thanks for the patch.  I'll try this out on a few other systems to see 
whether this behaviour is "normal" or a bug.  If the current behaviour 
is consistent with other systems then I'll commit this (otherwise it 
becomes documented behaviour that we then can't fix without a 
deprecation period).
Comment 4 Ceri Davies freebsd_committer freebsd_triage 2008-11-02 22:43:17 UTC
Responsible Changed
From-To: ceri->freebsd-bugs

I don't really belong in the FreeBSD project any more, so sorry for  
sitting on this for so long.
Comment 5 Thomas Abthorpe freebsd_committer freebsd_triage 2009-01-30 19:25:06 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-doc

doc PR
Comment 6 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:06 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-03-04 13:56:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=fc1e79740e4a83013aa0050fc95a991ec9c78e27

commit fc1e79740e4a83013aa0050fc95a991ec9c78e27
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2021-02-09 09:11:22 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-03-04 13:52:12 +0000

    compress(1): warn about link handling

    compress(1) handles links badly and does not provide link-handling options.
    Document this behavior.

    PR:     84271
    Submitted by: garys@opusnet.com
    Approved by: gbe@ (mentor)
    Differential Revision:  https://reviews.freebsd.org/D28552

 usr.bin/compress/compress.1 | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2021-03-04 13:58:44 UTC
Committed,

Thanks!