Bug 87859 - [smbfs] System reboot while umount smbfs.
Summary: [smbfs] System reboot while umount smbfs.
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrey V. Elsukov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-23 05:50 UTC by Ven
Modified: 2014-05-02 22:34 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ven 2005-10-23 05:50:16 UTC 
system will reboot while umount smbfs after network broken.

How-To-Repeat: 1. mount_smbfs -N //lyx/download /mnt
2. close windows xp machine.(broken network)
3. umount /mnt (system will reboot)
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-05-18 05:22:56 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-17 13:22:11 UTC 
Author: ae
Date: Thu Apr 17 12:22:08 2014
New Revision: 264600
URL: http://svnweb.freebsd.org/changeset/base/264600

Log:
  Remove redundant unlock.
  
  This code was removed from the opensolaris and darwin's
  netsmb implementations, in DfBSD it also has been disabled.
  
  PR:		36566, 87859, 139407, 161579, 175557, 178412, 186652
  MFC after:	2 weeks
  Sponsored by:	Yandex LLC

Modified:
  head/sys/netsmb/smb_iod.c

Modified: head/sys/netsmb/smb_iod.c
==============================================================================
--- head/sys/netsmb/smb_iod.c	Thu Apr 17 12:16:51 2014	(r264599)
+++ head/sys/netsmb/smb_iod.c	Thu Apr 17 12:22:08 2014	(r264600)
@@ -87,8 +87,6 @@ smb_iod_invrq(struct smbiod *iod)
 	 */
 	SMB_IOD_RQLOCK(iod);
 	TAILQ_FOREACH(rqp, &iod->iod_rqlist, sr_link) {
-		if (rqp->sr_flags & SMBR_INTERNAL)
-			SMBRQ_SUNLOCK(rqp);
 		rqp->sr_flags |= SMBR_RESTART;
 		smb_iod_rqprocessed(rqp, ENOTCONN);
 	}
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Andrey V. Elsukov freebsd_committer freebsd_triage 2014-05-02 22:33:23 UTC 
State Changed
From-To: open->closed

Fixed in head/ and stable/10.
Comment 4 Andrey V. Elsukov freebsd_committer freebsd_triage 2014-05-02 22:33:23 UTC 
Responsible Changed
From-To: freebsd-fs->ae

Take it.