Bug 88821 - [patch] IPv6 support for ggated(8)
Summary: [patch] IPv6 support for ggated(8)
Status: Closed Feedback Timeout
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 6.0-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
Depends on:
Reported: 2005-11-11 01:10 UTC by Craig Boston
Modified: 2020-09-19 16:33 UTC (History)
3 users (show)

See Also:

ggate_ipv6_2.patch (21.17 KB, patch)
2005-11-11 01:10 UTC, Craig Boston
no flags Details | Diff
ggate-ipv6-sctp-debug.diff (30.34 KB, patch)
2009-03-26 06:50 UTC, ota
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Boston 2005-11-11 01:10:16 UTC
	Adds full IPv6 support to ggated and complete address family
	independence to ggatec.

How-To-Repeat: 	n/a
Comment 1 Pawel Jakub Dawidek freebsd_committer 2005-11-11 11:54:22 UTC
Responsible Changed
From-To: freebsd-bugs->pjd

This one is for me. Thanks.
Comment 2 Craig Boston 2005-11-18 03:55:37 UTC
Argh, I could have sworn I compiled this will full warnings enabled
before submitting.

In countmask(), this section:

+	switch (addr->sa_family) {
+		case AF_INET:
+			alen = 4;	/* 32 bits */
+			ap = (unsigned char*)&((struct sockaddr_in*)addr)->sin_addr.s_addr;
+			mp = (unsigned char*)&((struct sockaddr_in*)&ss)->sin_addr.s_addr;
+			break;
+		case AF_INET6:
+			alen = 16;	/* 128 bits */
+			ap = (unsigned char*)&((struct sockaddr_in6*)addr)->sin6_addr.s6_addr;
+			mp = (unsigned char*)&((struct sockaddr_in6*)&ss)->sin6_addr.s6_addr;
+			break;
+		default:
+			g_gate_xlog("Unknown address family in countmask");
+	}

There should be an extra line after the g_gate_xlog:

+			return ss;

Comment 3 ota 2009-03-26 06:50:38 UTC
I also implemented SCTP on top of IPv6 support patch.
Passing "-P sctp -n" to both ggated and ggated will enable it.

-n option is added to disable NO_TCP_DELAY.
-f option is added to ggated and ggatec create/rescue to run in foregraound
-F option is added; -F4 to specify IPv4, -F6 for IPv6, and -F0 for both. 
-P option is added to support SCTP; it uses /etc/protocols so that if
protocol passed to the program is really applicable, other protocols may
work as well.

If the patch is to be commited, I can also send its man page updates.

Comment 4 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:31 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 5 Tom Jones freebsd_committer 2020-07-11 14:20:06 UTC
We had a quick look at this during the July 2020 bugathon. The best course of action is to create a review on reviews.freebsd.org and adding freebsd-net as a reviewer. 

If there are no further updates in the next 6 months we will close this issue.
Comment 6 Tom Jones freebsd_committer 2020-09-19 16:33:09 UTC
Next bugathon came around a bit soon, please create a review if you wish the change to land.