I did a stupid thing with my initial pass at FAM support. I exposed WANT_FAM_SYSTEM to users when it is clearly only meant for porters. This patch corrects that problem by using WITH_FAM_SYSTEM as a user tunable. It also (finally) makes gamin the default FAM system.
Responsible Changed From-To: freebsd-ports-bugs->portmgr Over to the keepers of the flame.
State Changed From-To: open->analyzed Accepted for testing on the cluster.
Consider the following scenario: A port defines WANT_FAM_SYSTEM=3Dfam. A user without WITH_FAM_SYSTEM explicitly set in his make.conf, and with devel/gamin installed since before then installs this port. I think the dependency on fam.0 will then be satisfied, eventhough what he really has is Gamin. Would anyone mind the following? (patch against HEAD): --- bsd.port.mk.orig Wed Jan 4 12:07:38 2006 +++ bsd.port.mk Wed Jan 4 12:08:29 2006 @@ -1498,7 +1498,7 @@ .if ${WANT_FAM_SYSTEM} =3D=3D fam LIB_DEPENDS+=3D fam.0:${PORTSDIR}/devel/fam .elif ${WANT_FAM_SYSTEM} =3D=3D gamin -LIB_DEPENDS+=3D fam.0:${PORTSDIR}/devel/gamin +LIB_DEPENDS+=3D gamin-1.1:${PORTSDIR}/devel/gamin .else BROKEN=3D "unknown FAM system: ${WANT_FAM_SYSTEM}" .endif Best regards, Aron Stansvik PS. I'm not subscribed, so Cc would be nice. DS.
My e-mail client did something bad to the equal signs in the patch. Sorry about that, but you get what I mean, just change fam.0:${PORTSDIR}/devel/gamin to gamin-1.1:${PORTSDIR}/devel/gamin. Aron
State Changed From-To: analyzed->closed Committed, thanks.