Bug 90680 - [patch] make(1) thinks "^.for.o:" is a directive (".for something in ...")
Summary: [patch] make(1) thinks "^.for.o:" is a directive (".for something in ...")
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 6.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-20 13:20 UTC by Dr. Andreas Haakh
Modified: 2018-02-18 07:21 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dr. Andreas Haakh 2005-12-20 13:20:02 UTC
              Make interprets a rule like ".for.o:" as a ".for"-directive.

Fix: Following patch solves the problem for me but if a suffix equals any other directive, the same error will probably show up.


/*
+        * for is only valid if a space-character comes next
+        */
+       if (!isspace((u_char)*ptr))
+           return (FALSE);
+
+       /*
         * Skip space between for and the variable.
         */
        for (ptr++; *ptr && isspace((u_char)*ptr); ptr++)--GXSjIh9nLAFOVcBLDCrp1rAK0eEnR5q5c2Wortyz9GH4nvDD
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- make/for.c  Tue May 10 14:02:15 2005
+++ makeX/for.c Tue Dec 20 13:37:23 2005
@@ -101,6 +101,12 @@
        ptr = line;
How-To-Repeat: Create a Makefile containing
.SUFFIXES: .for
.for.o:

and run make.
Comment 1 Dr. Andreas Haakh 2006-06-21 07:15:58 UTC
Hello,

is it possible to implement the patch I have submitted? It would take 
five minutes and the pr could be closed...

Andreas
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:29 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Alex Kozlov freebsd_committer freebsd_triage 2018-02-18 07:21:26 UTC
Fixed in all supported versions of FreeBSD after import of bmake.