Bug 92018 - [PATCH] Port sysutils/dvd+rw-tools does not work on FreeBSD 4
Summary: [PATCH] Port sysutils/dvd+rw-tools does not work on FreeBSD 4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-19 19:30 UTC by Sven Berkvens-Matthijsse
Modified: 2006-01-20 13:27 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Berkvens-Matthijsse 2006-01-19 19:30:09 UTC
	The current version of growisofs uses threads and does not work
	correctly under FreeBSD 4. This is because the pthread_attr_setscope()
	call that growisofs uses is not supported on FreeBSD 4.

Fix: I've included a patch to go in files/patch-mp.h :



The patch makes sure that the pthread_attr_setscope() call does not
	take place for FreeBSD versions under 5.x.--9e8eYSHEmmvRxXcdZhme6pG76Ibo7ziJilMIS3POVf1NSywe
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- mp.h.orig	Mon Jan 16 11:34:56 2006
+++ mp.h	Thu Jan 19 20:22:30 2006
@@ -39,7 +39,9 @@
   pthread_attr_t attr;
 
     if (pthread_attr_init(&attr)==0 &&
+#if	!defined(__FreeBSD__) || __FreeBSD__ >= 5
 	pthread_attr_setscope(&attr,PTHREAD_SCOPE_SYSTEM)==0 &&
+#endif	/* FreeBSD 4 does not support PTHREAD_SCOPE_SYSTEM */
 	pthread_create(&h,&attr,(void *(*)(void *))func,arg)==0 )
 	return (void *)h;
 
How-To-Repeat: 	Try to burn a DVD on FreeBSD 4 with growisofs.
Comment 1 Pav Lucistnik freebsd_committer 2006-01-20 12:23:28 UTC
Dear maintainer of FreeBSD port sysutils/dvd+rw-tools, please take a
look at

http://www.freebsd.org/cgi/query-pr.cgi?q=92018

Do you approve this patch?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

What do we know about love? Love is like a pear.  Pear is sweet and have
a specific shape. Try to exactly define the shape of a pear.
  -- Marigold: 50 Years Of Poetry
Comment 2 Pav Lucistnik freebsd_committer 2006-01-20 12:23:32 UTC
State Changed
From-To: open->feedback

Asked maintainer for approval 


Comment 3 Pav Lucistnik freebsd_committer 2006-01-20 12:23:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Track
Comment 4 Chuck Swiger 2006-01-20 13:10:55 UTC
Pav Lucistnik wrote:
> Dear maintainer of FreeBSD port sysutils/dvd+rw-tools, please take a
> look at
> 
> http://www.freebsd.org/cgi/query-pr.cgi?q=92018
> 
> Do you approve this patch?

I have some other changes pending with regard to supporting FreeBSD-4, but I 
don't want to hold them up, so yes, I approve this change.

-- 
-Chuck
Comment 5 Pav Lucistnik freebsd_committer 2006-01-20 13:26:59 UTC
State Changed
From-To: feedback->closed

Committed, thanks!