Bug 92054 - ports/net-im/jabber-py(icq|msn) rc.d files misbehave
Summary: ports/net-im/jabber-py(icq|msn) rc.d files misbehave
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-20 12:10 UTC by Lapo Luchini
Modified: 2006-01-23 10:48 UTC (History)
1 user (show)

See Also:


Attachments
jabber-pyicq-transport.sh (831 bytes, text/plain)
2006-01-20 12:10 UTC, Lapo Luchini
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lapo Luchini 2006-01-20 12:10:14 UTC
The rc.d scripts distributed with
  ports/net-im/jabber-pyicq
and
  ports/net-im/jabber-pymsn
don't honor the variables put in rc.conf.

Fix: I did the following mods the rc.d files and found some probable errors:

Changed
  jabber_pyicq_dir=${jabberd_pyicq_dir-"/usr/local/lib/jabber/pyicq"}
to
  jabber_pyicq_dir=${jabber_pyicq_dir:-"/usr/local/lib/jabber/pyicq"}

Moved
  load_rc_config $name
higher in the file, else the command_ lines do not "see"
the rc.conf settings.

Added the missing -o option to
  command_args="-o pid=${pidfile} &"

Follows my full working pyicq script.
pymsn needed the same mods but also seems that xml file configuration
about the PID file overrides the one passed as -o, differently
from pyicq.
How-To-Repeat: 
Change some vars in rc.conf and "start" the service.
Comment 1 Edwin Groothuis freebsd_committer 2006-01-20 12:13:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

Over to maintainer
Comment 2 Renato Botelho freebsd_committer 2006-01-23 10:48:07 UTC
State Changed
From-To: open->closed

Committed. Please, send another PR with the patch to be applied in 
jabber-pymsn, i'm not the maintainer of this port and can't make the 
changes. Thanks for contributing!