I'd like to propose a patch for kismet port. The changes are: - Use OPTIONS instead of DISABLE_FOO. IMHO, it's much more clean - Use additional tweaking and dependancy tracking to build gpsmap along with kismet. I wonder why not to build gpsmap with kismet, then it is included in kismet distro? Current port fails with gpsmap. My fixes allows gpsmap to be built. I've decide to submit patch to ports@ after two emails I sent to maintainer, but didn't get his reply. The changes are not so big and dramatical, so I hope he is ok to it. Fix: see proposed patch
State Changed From-To: open->feedback Awaiting maintainers feedback
Responsible Changed From-To: freebsd-ports-bugs->novel I will take it.
hmmm...never seen an email concerning this until now ... wonder if it got caught in my spam filters. My cursory review on the patch though looks good. Thanks much for the cleanup Anton. -Peter
Peter Thoenen wrote: > hmmm...never seen an email concerning this until now ... wonder if it > got caught in my spam filters. My cursory review on the patch though > looks good. Thanks much for the cleanup Anton. > > -Peter I've hacked on the submitted patch a bit. I've fixed build on 4.x by disabling pcap support on it, added a forgotten file to pkg-plist and removed hardcoded -lpthread from configure. Are you OK about it? The patch is here: http://people.freebsd.org/~novel/misc/kismet.diff Roman Bogorodskiy
On Tue, Jan 24, 2006 at 08:47:37PM +0000, Roman Bogorodskiy wrote: > Peter Thoenen wrote: > > hmmm...never seen an email concerning this until now ... wonder if it > > got caught in my spam filters. My cursory review on the patch though > > looks good. Thanks much for the cleanup Anton. > > > > -Peter Thanks. If you wish, I'll send you my mail server log records (to see when exactly mails were sent). > I've hacked on the submitted patch a bit. I've fixed build on 4.x by > disabling pcap support on it, added a forgotten file to pkg-plist and > removed hardcoded -lpthread from configure. Are you OK about it? > The patch is here: http://people.freebsd.org/~novel/misc/kismet.diff I cannot try it to work on 4.x and doubt it might be useful on 4.x due to poor wireless support and (AFAIK) lack of radiotap_bsd support in 4.x. I doubt it's useful to be able only to build software not to use it ;) Correct me if I wrong! The rest of patch is ok. -- Anton A. Karpov WWW: http://www.toxahost.ru PGP Key ID: A21386F2 =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~= (__) FreeBSD \\\'',) Unix the way *I* like it \/ \ ^ .\._/_) http://www.FreeBSD.ORG =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=
Anton A. Karpov wrote: > I cannot try it to work on 4.x and doubt it might be useful on > 4.x due to poor wireless support and (AFAIK) lack of radiotap_bsd support > in 4.x. I doubt it's useful to be able only to build software not to use > it ;) Correct me if I wrong! > The rest of patch is ok. I can't test if it is usable or not on 4.x. I did my tests of the packaging stuff on a 4.x box so fixed build on it. In case somebody reports that it is not usable on 4.x, we will mark it IGNORE. Roman Bogorodskiy
Unable to test on 4.x (or even 5.x for that matter) here so not able to weigh in on the second part of this. Took over maintainership after 5.x was out so unfamiliar with the 4.x issues or why it was marked bad ... I just left the nobuild options in from the previous maintainer.
State Changed From-To: feedback->closed Committed, thanks!