Just a tiny problem, but it makes the man page look damaged. Please note that running `make` already executes `nroff -man xephem.man > xephem.1` in ${WRKSRC}. Thus xephem.1 is a formatted man page (i.e., cat page) which should not be installed in ${PREFIX}/man/man1 because `man xephem` will later attempt another formatting. The result isn't really enjoyable. Fix: Adding the line @${CP} ${WRKSRC}/xephem.man ${WRKSRC}/xephem.1 to the pre-install target should work.
State Changed From-To: open->feedback Awaiting maintainers feedback
On Wednesday 22 February 2006 16:24, Edwin Groothuis wrote: > Maintainer of astro/xephem, > > Please note that PR ports/93728 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the > patch and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/93728 Yep, looks good to me. -- Thanks, Josh Paetzel
Here's a patch that will hopefully expedite getting this pr committed. --- Makefile.old Thu Mar 16 13:57:14 2006 +++ Makefile Thu Mar 16 13:58:16 2006 @@ -54,6 +54,7 @@ pre-install: @${FIND} ${WRKSRC}/../.. -name Makefile.bak -type f | ${XARGS} ${RM} -f + @${CP} ${WRKSRC}/xephem.man ${WRKSRC}/xephem.1 do-install: ${INSTALL_PROGRAM} ${WRKSRC}/xephem ${PREFIX}/bin -- Thanks, Josh Paetzel
Responsible Changed From-To: freebsd-ports-bugs->glewis I'll take it.
State Changed From-To: feedback->closed Committed. Thanks!