Bug 95095 - Re: patch for gmake
Summary: Re: patch for gmake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ade Lovett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-30 03:40 UTC by NAKATA Maho
Modified: 2006-03-30 04:50 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description NAKATA Maho 2006-03-30 03:40:16 UTC 
 In Message-ID: <CFF39396-9FF9-4B9B-BC37-DE54CB0364E5@freebsd.org> 
 Ade Lovett <ade@freebsd.org> wrote:
 
 > 
 > On Mar 27, 2006, at 14:03 , NAKATA Maho wrote:
 > 
 > > Hello ade,
 > > a patch for gmake has been submitted. Could you please invesitvate  
 > > this?
 > > patch is merely using hash rather than directly using malloc.
 > > I think it is safe...and we don't need devel/gmake-devel any more.
 > 
 > I'm waiting for an updated version of the patch that conforms to the  
 > guidelines laid out in the Porters Handbook.  Once that's been taken  
 > care of, it will get scheduled for an -exp build run at some  
 > convenient time.
 
 Thanks for your reply. I reviwed gmake.diff by Robert Muir again
 but I don't see a problem(it does bump portrevision correctly and
 merely adding patches). Could you please where is the point which
 violate the guidebook?
 
 All the best,
 -- NAKATA, Maho (maho@FreeBSD.org)
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2006-03-30 04:37:44 UTC 
State Changed
From-To: open->closed

I can't figure out which base PR this was supposed to apply to.  Close it 
but assign it to ade@ so followups wind up somewhere useful.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2006-03-30 04:37:44 UTC 
Responsible Changed
From-To: gnats-admin->ade


http://www.freebsd.org/cgi/query-pr.cgi?pr=95095 

Adding to audit trail:

This apparently applies to ports/94526.
Comment 3 Ade Lovett freebsd_committer freebsd_triage 2006-03-30 04:44:28 UTC 
Just for tracking purposes, the PR containing the patch which will be  
set up for an -exp run is 94526.

As and when 5.5/6.1 RELEASEs are out the door, I'll co-ordinate with  
portmgr@ on getting the run done.

-aDe