add a quirk table entry for a flash ram usb stic Fix: I append a patch, which will also appear here: http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/sys/cam/scsi/scsi_da.c.integral.REL=ALL.diff I suggest commit it keeping the first comment beginning "Label on outside" but deleting 2nd comment beginning "This stick works" which is just for your committer info.
I forgot the patch ! I just gave a URL to it. Here it is. I forgot to mention that in current src/ at time of submission Wed Apr 26 22:41:11 CEST 2006 no one else had added this quirk table entry yet, so its worth adding (even though the diff was created on a 6.0-RELEASE, not 6.1-PRERELEASE (which I'm about to do) *** 6.0-RELEASE/src/sys/cam/scsi/scsi_da.c Thu Jun 9 19:35:04 2005 --- new-generic/src/sys/cam/scsi/scsi_da.c Wed Apr 26 18:24:56 2006 *************** *** 354,359 **** --- 354,402 ---- {T_DIRECT, SIP_MEDIA_REMOVABLE, "Kingston" , "DataTraveler II+", "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE }, + { + /* Label on outside: "integral 1GB USB 2.0 Flash Drive" + * cam/scsi/scsi_all.c scsi_inquiry_match() inq->vendor + * Shows 8 spurious spaces for just this flash stick. + * " USB DISK Pro PMAP" + * Detected by stick owner "Julian H. Stacey" <jhs@berklix.com> + * PS a "*" works as well as a " " in next line of code. + */ + /* This stick works without this patch, but then in /var/log/messages: + * (This stick is lockable, when unlocked it appears with /dev/da0 /dev/da0s1 /dev/da1 ). + * umass0: vendor 0x0d7d USB DISK Pro, rev 2.00/1.00, addr 3 + * umass0: SCSI over Bulk-Only; quirks = 0x0000 + * umass0:3:0:-1: Attached to scbus3 + * da0 at umass-sim0 bus 0 target 0 lun 0 + * da0: < USB DISK Pro PMAP> Removable Direct Access SCSI-0 device + * da0: 1.000MB/s transfers + * da0: 978MB (2003968 512 byte sectors: 64H 32S/T 978C) + * da1 at umass-sim0 bus 0 target 0 lun 1 + * da1: < USB DISK Pro PMAP> Removable Direct Access SCSI-0 device + * da1: 1.000MB/s transfers + * da1: 1MB (2880 512 byte sectors: 64H 32S/T 1C) + * umass0: Phase Error, residue = 0 + * (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da1:umass-sim0:0:0:1): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da1:umass-sim0:0:0:1): Synchronize cache failed, status == 0x4, scsi status == 0x0 + * umass0: Phase Error, residue = 0 + * (da1:umass-sim0:0:0:1): Synchronize cache failed, status == 0x4, scsi status == 0x0 + */ + {T_DIRECT, SIP_MEDIA_REMOVABLE, " ", "USB DISK Pro", "PMAP" }, + /*quirks*/ DA_Q_NO_SYNC_CACHE + }, }; static disk_strategy_t dastrategy; ----------- Julian -- Julian Stacey. Consultant Unix Net & Sys. Eng., Munich. http://berklix.com Mail in Ascii, HTML=spam. Ihr Rauch = mein allergischer Kopfschmerz.
Responsible Changed From-To: freebsd-bugs->freebsd-usb Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=96381 Adding to audit trail from misfiled PR usb/120297: Date: Tue, 05 Feb 2008 18:50:24 +0100
Responsible Changed From-To: freebsd-usb->eadler I'll take it.
State Changed From-To: open->analyzed awaiting approval / review
State Changed From-To: analyzed->closed Committed. Thanks!