Bug 99371 - [maintainer] fix serious installation bugs in cups-base
Summary: [maintainer] fix serious installation bugs in cups-base
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-23 16:10 UTC by Sergey Akifyev
Modified: 2006-06-24 09:14 UTC (History)
1 user (show)

See Also:

Attachments
cups-base.diff (1.42 KB, patch)
2006-06-23 16:10 UTC, Sergey Akifyev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Akifyev 2006-06-23 16:10:22 UTC 
* Fixes problems with updating CUPS installation (Udo Schweigert)
* Fixes conflict with PHP5 when WITH_PHP is not enabled
Comment 1 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-06-23 21:21:19 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-06-23 21:24:41 UTC 
Responsible Changed
From-To: itetcu->freebsd-ports-bugs

I can't easly test this since I still use PHP4 on all my machines.
Comment 3 mwisnicki 2006-06-24 00:46:03 UTC 
Please commit that patch. Without it, configure will autodetect and
enable php (any version) even when disabled with make config.

Additionally if you have php5 without php4 this will break the build.

I think that python is also autodetected and should be explicitly
disabled in .else clause:

--- cups-base.diff begins here ---
diff -ruN cups-base.orig/Makefile cups-base/Makefile
--- cups-base.orig/Makefile       Fri Jun 23 00:01:38 2006
+++ cups-base/Makefile    Sat Jun 24 01:42:45 2006
@@ -77,6 +77,8 @@
 .if defined(WITH_PYTHON)
 CONFIGURE_ARGS+=       --with-python
 USE_PYTHON=            yes
+.else
+CONFIGURE_ARGS+=       --without-python
 .endif
 
 .if defined(WITH_LIBPAPER)
--- cups-base.diff ends here ---
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-06-24 09:09:42 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 5 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-06-24 09:14:47 UTC 
State Changed
From-To: open->closed

Committed. Thanks!