Bug 263112 - sysutils/lttng-ust: Tentative update to 2.13.2 [patch]
Summary: sysutils/lttng-ust: Tentative update to 2.13.2 [patch]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-04-07 08:35 UTC by Sean Champ
Modified: 2023-10-29 22:59 UTC (History)
1 user (show)

See Also:


Attachments
tentative diff (37.26 KB, patch)
2022-04-07 08:35 UTC, Sean Champ
no flags Details | Diff
updated diff (41.91 KB, patch)
2022-04-07 16:23 UTC, Sean Champ
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Champ 2022-04-07 08:35:32 UTC
Created attachment 233017 [details]
tentative diff

lttng-ust may eventually be of some  use in developing a port system for cross-building .NET tools for FreeBSD. At one point in the dotnet/runtime cross-build, liblttng-ust (for FreeBSD) may need to have been installed under a FreeBSD base system installed within a Linux environment for the cross-build. 

I wasn't able to build to the port, at the version presntly available in ports.

The latest upstream release for lttng-ust is 2.13.2 

The diff attached to this would allow for at least building the port. Candidly, I'm not very well familiar with the upstream project. Some of the files have been renamed, some of the files substantially updated. I've tried to update the patches to the best of my understanding of the codebase.

It builds successfully and can now be used for testing for a dotnet cross-build, for FreeBSD[1]

[1] https://github.com/dotnet/source-build/issues/1139
Comment 1 Sean Champ 2022-04-07 15:51:10 UTC
I'll try to provide an updated patch soon. In some initial Q/A about the first diff I'd provided, this morning:

With the port updated with the patch as provided,  when building the port directly under /usr/ports I was able to build up to the point of 'make build'. It fails in check-plist

With the same updated port, but when building under poudriere, it failed in the 'configure' stage on a syntax error in the configure script. I'm not sure how that's not turning up during the direct build under /usr/ports, will take a look at that and for the plist update
Comment 2 Sean Champ 2022-04-07 16:03:35 UTC
In the build under poudriere, I'm not sure why this is showing up as a literal expression in ${WRKSRC}/configure:

~~~~
# Require URCU >= 0.12 for DEFINE_URCU_TLS_INIT
PKG_CHECK_MODULES(URCU, liburcu >= 0.12)  
~~~~

With the build under /usr/ports/sysutils/lttng-ust for the update, that autoconf macro was expanded properly. Maybe there's an additional build dependency somewhere?
Comment 3 Sean Champ 2022-04-07 16:23:03 UTC
Created attachment 233033 [details]
updated diff

this diff provides the updates presented in the previous diff, also updating pkg-plist and adding pkgconfig to USES for sysutils/lttng-ust 2.13.2
Comment 4 Sean Champ 2022-04-07 17:59:34 UTC
lttng-ust 2.13 may not be ABI-compatible with lttng-ust 2.12. There's a discussion under the dotnet/runtime QA section:
https://github.com/dotnet/runtime/issues/57784
Comment 5 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:40:52 UTC
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-29 22:58:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=339c2277cfc84002238b7529866ae96971124b90

commit 339c2277cfc84002238b7529866ae96971124b90
Author:     Sean Champ <lab+bsd@thinkum.space>
AuthorDate: 2023-10-29 10:58:34 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-10-29 22:53:30 +0000

    sysutils/lttng-ust: Update version 2.9.0=>2.13.2

    Some of the patches retained here may be out of scope now, such as those
    patches still adding a definition for NT_GNU_BUILD_ID.

    Changelog:
    https://git.lttng.org/?p=lttng-ust.git;a=blob_plain;f=ChangeLog;hb=ac8d9a90b1e9052d2dea77e0b0c92b779bceb4a8

    PR:             263112

 sysutils/lttng-ust/Makefile                        |  18 +--
 sysutils/lttng-ust/distinfo                        |   6 +-
 .../lttng-ust/files/patch-config_libtool.m4 (gone) |  15 --
 .../patch-doc_examples_clock-override_Makefile     |  10 +-
 ...shared-libraries_cmake_FindLTTngUST.cmake (new) |  18 +++
 .../files/patch-doc_examples_demo-tracef_Makefile  |  10 +-
 .../patch-doc_examples_demo-tracelog_Makefile      |  10 +-
 .../files/patch-doc_examples_demo_Makefile         |  10 +-
 .../files/patch-doc_examples_easy-ust_Makefile     |  10 +-
 .../files/patch-doc_examples_gen-tp_Makefile       |  14 +-
 .../patch-doc_examples_getcpu-override_Makefile    |  10 +-
 .../patch-doc_examples_hello-static-lib_Makefile   |  13 +-
 sysutils/lttng-ust/files/patch-doc_man_lttng-ust.3 |  55 +++++---
 .../lttng-ust/files/patch-doc_man_lttng-ust.3.txt  |  48 +++----
 .../files/patch-include_lttng_ust-dlfcn.h (gone)   |  11 --
 .../files/patch-include_lttng_ust-elf.h (gone)     |  22 ---
 .../patch-include_lttng_ust-tracepoint-event.h     |  26 ++--
 .../patch-liblttng-ust-ctl_Makefile.am (gone)      |   9 --
 .../patch-liblttng-ust-ctl_Makefile.in (gone)      |  11 --
 .../files/patch-liblttng-ust-ctl_ustctl.c (gone)   |  31 ----
 .../files/patch-liblttng-ust-dl_ust__dl.h (gone)   |  10 --
 .../patch-liblttng-ust-fd_lttng-ust-fd.c (gone)    |  11 --
 .../files/patch-liblttng-ust_Makefile.am (gone)    |  10 --
 .../files/patch-liblttng-ust_Makefile.in (gone)    |  10 --
 .../files/patch-liblttng-ust_compat.h (gone)       |  20 ---
 .../lttng-ust/files/patch-lttng-ust.pc.in (gone)   |  10 --
 sysutils/lttng-ust/files/patch-m4_libtool.m4 (new) | 157 +++++++++++++++++++++
 .../files/patch-src_common_compat_dlfcn.h (new)    |  11 ++
 .../lttng-ust/files/patch-src_common_elf.h (new)   |  14 ++
 .../patch-src_lib_lttng-ust-ctl_ustctl.c (new)     |  14 ++
 .../patch-src_lib_lttng-ust-dl_ust__dl.h (new)     |  10 ++
 .../files/patch-src_lib_lttng-ust.pc.in (new)      |  10 ++
 sysutils/lttng-ust/pkg-plist                       |  88 +++++++-----
 33 files changed, 391 insertions(+), 341 deletions(-)