207666 – security/py-{acme,letsencrypt}: Update to 0.4.1

Bug 207666 - security/py-{acme,letsencrypt}: Update to 0.4.1

Summary: security/py-{acme,letsencrypt}: Update to 0.4.1

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Carlos J. Puga Medina

URL:
Keywords:	easy, patch, patch-ready

Depends on:
Blocks:

Reported:	2016-03-03 01:48 UTC by Carlos J. Puga Medina
Modified:	2016-03-03 05:44 UTC (History)
CC List:	3 users (show)

See Also:

Flags:	cpm: maintainer-feedback+

Attachments
patch (870 bytes, patch) 2016-03-03 01:48 UTC, Carlos J. Puga Medina	cpm: maintainer-approval+	Details \| Diff
py-letsencrypt patch (779 bytes, patch) 2016-03-03 03:46 UTC, Carlos J. Puga Medina	koobs: maintainer-approval+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Carlos J. Puga Medina freebsd_committer

2016-03-03 01:48:57 UTC

Created attachment 167663 [details]
patch

- Update to 0.4.1
- Update MAINTAINER to my @FreeBSD.org address

Comment 1 Carlos J. Puga Medina freebsd_committer

2016-03-03 01:58:25 UTC

All builds are fine via poudriere on 9.3a+i and 10.2a+i.

Comment 2 Jason Unovitch freebsd_committer

2016-03-03 03:11:24 UTC

Is this update dependent on Letsencrypt in that it that needs an approval from koobs@ or is the CC just purely for the CC?  If there's no dependence then this is approved for commit.

Comment 3 Carlos J. Puga Medina freebsd_committer

2016-03-03 03:18:10 UTC

(In reply to Jason Unovitch from comment #2)

Yes, this update depends on letsencrypt :)

Comment 4 Jason Unovitch freebsd_committer

2016-03-03 03:22:40 UTC

(In reply to Carlos J. Puga Medina from comment #3)
Mainly, does letsencrypt need to update from version X to version X+1 to go along with this.  If so we'll need the appropriate "depends on" or "blocks".  However, given that it's just a patch level bump from 0.4.0 -> 0.4.1, I am assuming it would work without any letsencrypt changes.

Comment 5 Carlos J. Puga Medina freebsd_committer

2016-03-03 03:27:05 UTC

(In reply to Jason Unovitch from comment #4)

You're right.  I assume that koobs@ will prepare letsencrypt update before I commit this PR.

Comment 6 Jason Unovitch freebsd_committer

2016-03-03 03:29:39 UTC

(In reply to Carlos J. Puga Medina from comment #5)
Ok, then once koobs@ has provided an approval this is ready for commit.

Comment 7 Kubilay Kocak freebsd_committer

2016-03-03 03:32:18 UTC

@Carlos, if you want to attach the letsencrypt update here and/or create a review in phabricator with both port changes I can review it there and you can commit both. Please include unit test confirmation too

Comment 8 Carlos J. Puga Medina freebsd_committer

2016-03-03 03:33:39 UTC

(In reply to Kubilay Kocak from comment #7)

I'm willing to do it :)

Comment 9 Carlos J. Puga Medina freebsd_committer

2016-03-03 03:46:21 UTC

Created attachment 167666 [details]
py-letsencrypt patch

- Update PORTVERSION and distinfo checksum (0.4.1)

Comment 10 Carlos J. Puga Medina freebsd_committer

2016-03-03 04:01:37 UTC

All builds are fine:

https://people.freebsd.org/~cpm/logs/py27-letsencrypt-93x32-default.log
https://people.freebsd.org/~cpm/logs/py27-letsencrypt-93x64-default.log
https://people.freebsd.org/~cpm/logs/py27-letsencrypt-10x32-default.log

Comment 11 Kubilay Kocak freebsd_committer

2016-03-03 04:53:26 UTC

Thanks Carlos.

Can you confirm the test suites pass for both ports please.

Also, for future issues, build logs as attachments or remote URL's are not needed. Instead just mention them in the issue description, or the phabricator review TEST PLAN section as follows:

portlint: OK (summary output)
testport: OK (poudriere: <versions>, <archs>, <options> tested)
unittest: OK (summary output)

Comment 12 Carlos J. Puga Medina freebsd_committer

2016-03-03 05:04:38 UTC

(In reply to Kubilay Kocak from comment #11)

portlint(1) output for both ports

% portlint -ac
WARN: Makefile: no port directory /usr/ports/devel/py-setuptools${PYTHON_SUFFIX} found, even though it is listed in RUN_DEPENDS.
0 fatal errors and 1 warning found.

Comment 13 Carlos J. Puga Medina freebsd_committer

2016-03-03 05:29:11 UTC

- py-acme unittest (OK)
- py-letsencrypt unittest (OK)

Comment 14 Kubilay Kocak freebsd_committer

2016-03-03 05:35:46 UTC

Approved

Comment 15 commit-hook freebsd_committer

2016-03-03 05:43:05 UTC

A commit references this bug:

Author: cpm
Date: Thu Mar  3 05:42:15 UTC 2016
New revision: 410009
URL: https://svnweb.freebsd.org/changeset/ports/410009

Log:
  Common:

  - Update PORTVERSION and distinfo checksum (0.4.1)

  security/py-acme:

  - Update MAINTAINER to my @FreeBSD.org address

  PR:		207666
  Approved by:	junovitch (mentor), koobs (maintainer, letsencrypt)

Changes:
  head/security/py-acme/Makefile
  head/security/py-acme/distinfo
  head/security/py-letsencrypt/Makefile
  head/security/py-letsencrypt/distinfo

Comment 16 Carlos J. Puga Medina freebsd_committer

2016-03-03 05:44:53 UTC

It's done!

Thanks Kubilay!