Bug 212123 - net/libgweather: Update to 3.18.2 release
Summary: net/libgweather: Update to 3.18.2 release
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL: https://bugzilla.gnome.org/show_bug.c...
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-08-24 22:13 UTC by Carlos J. Puga Medina
Modified: 2016-09-29 12:09 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)
cpm: merge-quarterly?


Attachments
libgweather-fix-metar-functionality (3.06 KB, patch)
2016-08-24 22:13 UTC, Carlos J. Puga Medina
no flags Details | Diff
patch-update-libgweather-3.18.2 (2.56 KB, patch)
2016-08-30 00:06 UTC, Carlos J. Puga Medina
cpm: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-24 22:13:14 UTC
Created attachment 174032 [details]
libgweather-fix-metar-functionality

According to 

http://weather.noaa.gov/mgetmetar.php

This Service is no longer available

In Accordance with NWS Service Change Notice 16-16 this service has been discontinued. Please see Weather.gov and tgftp.nws.noaa.gov (raw data)

Attached patch restores METAR functionality using the replacement www.aviationweather.org text data server.

While I'm here:

Add LICENSE block and record missing dependencies.
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-24 22:16:59 UTC
Tested on FreeBSD 10.3-RELEASE/amd64.
Comment 2 rkoberman 2016-08-29 00:19:49 UTC
I have applied this patch and have had no success with libgweather. It appears that the metar data is now at:
http://tgftp.nws.noaa.gov/data/observations/metar/stations/STATION.TXT

The metar_parse routine looks to be parsing a raw metar string, not any XML format. It appears the patch requestse data in XML. 

N.B. I have no familiarity with the code, so this this comment may be completely wrong, but the patch does not seem to get libgweather to work.
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-29 00:41:50 UTC
(In reply to rkoberman from comment #2)

Hi Kevin,

I tested the patch and gnome-weather works again.

I'm not sure why it doesn't work for you but it seems that this patch will be applied upstream.

Please, read for further details:

https://bugzilla.gnome.org/show_bug.cgi?id=770321
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-29 00:49:31 UTC
Can you provide more details about the problem that you have?
Comment 5 rkoberman 2016-08-29 04:32:17 UTC
Sorry, but I am missing something. I don't think the patch has a problem, but I do. I installed the patch and re-built the port and re-started mate-panel. I monitored network traffic and no packets to www.aviationweather.gov. So the problem is that something is keeping the old version of libgweather from being replaced in memory by the new one. Guess I'll need to do a reboot to be completely sure that I am running hte fixed version.

Thanks for the quick response that made me test to confirm what was (or was not) happening. I'll post another comment once I have confirmed the fix. Again, sorry for my error.
Comment 6 rkoberman 2016-08-29 05:08:29 UTC
Now totally confused. strings(1) on libgweather.so and it shows:
https://www.aviationweather.gov/adds/dataserver_current/httpparam

tcpdump -i wlan0 -p host www.aviationweather.gov still captures no packets at all.

I am now completely baffled as to what is going on, but I suspect that it is not the patch to libgweather.
Comment 7 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-29 10:39:03 UTC
If you are using MATE desktop, you need to apply this patch to net/libmateweather.

Did you do that?
Comment 8 rkoberman 2016-08-29 19:12:57 UTC
I'm so embarrassed! Of course I needed to patch libmateweather. I used Gnome2 and libgweather for so long that I never thought that MATE might have forked it.

All is now well for the current weather. Forecast still looks broken, probably or the same reason. I see the same patch is applied to MATE upstream and a proposal for fixing forecasts is being tested.

Thanks for working on this and sorry for the bogus report.
Comment 9 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-30 00:06:04 UTC
Created attachment 174207 [details]
patch-update-libgweather-3.18.2

Update libgweather to 3.18.2 release
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-09-29 11:57:56 UTC
A commit references this bug:

Author: kwm
Date: Thu Sep 29 11:57:15 UTC 2016
New revision: 422913
URL: https://svnweb.freebsd.org/changeset/ports/422913

Log:
  Update libgweather to 3.18.2.

  * NOAA shut down their METAR provider service, so libgweather
    switched to a different provider.
  * Record indirect dependancies
  * Add License block
  * Add USES=localbase instead of CPPFLAGS/LDFLAGS

  PR:		212123
  Submitted by:	cpm@

Changes:
  head/net/libgweather/Makefile
  head/net/libgweather/distinfo
  head/net/libgweather/pkg-plist
Comment 11 Koop Mast freebsd_committer freebsd_triage 2016-09-29 12:09:03 UTC
Committed thanks!