Bug 214289 - x11-wm/mutter: Update to 3.18.4
Summary: x11-wm/mutter: Update to 3.18.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-11-06 23:22 UTC by Carlos J. Puga Medina
Modified: 2016-12-02 22:01 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
patch-mutter-3.18.4 (2.21 KB, patch)
2016-11-06 23:22 UTC, Carlos J. Puga Medina 		no flags Details | Diff
patch-mutter-3.18.4 (2.21 KB, patch)
2016-11-12 17:08 UTC, Carlos J. Puga Medina 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-06 23:22:41 UTC 
Created attachment 176706 [details]
patch-mutter-3.18.4

x11-wm/mutter:

- Update mutter to 3.18.4
- Add LICENSE and LICENSE_FILE
- Record TIMESTAMP and distinfo checksum (3.18.4)
- Regenerate patches with make makepatch
- Add WWW to pkg-descr
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-06 23:28:30 UTC 
GDM issue after x11/libxkbcommon update to 0.6.1 and it dependencies. So GDM cannot start properly.

From /var/log/gdm/:0-greeter.log.*

usr/local/lib/libxkbcommon-x11.so.0: version V_0.5.0 required by /usr/local/lib/libmutter.so.0 not defined

While this update get committed, reinstall mutter port fix the issue.
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-07 02:21:00 UTC 
All builds are fine on 9.3/ia, 10.2/ia and 10.3/ia
Comment 3 Mark Felder freebsd_committer freebsd_triage 2016-11-11 23:13:51 UTC 
Approved
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-11-12 12:41:07 UTC 
LICENSE is incorrect, it should be "GPLv2+" (see source files for "or (at your option) any later version" clause). Otherwise good.
Comment 5 Mark Felder freebsd_committer freebsd_triage 2016-11-12 16:54:58 UTC 
Sorry, good catch. I've been dealing with a branch at work that doesn't support the License+ format so I overlooked it.
Comment 6 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-12 17:08:01 UTC 
Created attachment 176929 [details]
patch-mutter-3.18.4

Fix LICENSE
Comment 7 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-12 17:10:19 UTC 
Yes, good catch, Dmitry.

I'm waiting for Koop's feedback.

Thanks to both of you :)
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-15 10:05:30 UTC 
I see no reference to why merge-quarterly might be required for this change.

Please provide addition information
Comment 9 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-15 11:44:37 UTC 
(In reply to Kubilay Kocak from comment #8)

It fix a GDM start issue in some cases. I had this problem as well.

See comment #c1

If you think that it's not necessary, please let me know and I'll remove the MFH flag.
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-15 11:48:13 UTC 
The decision to merge is yours, I only asked the question because the rationale wasn't obvious from the proposed commit log (it should be)

Bugfixes should be merged, ideally without feature updates if they can be separated, or committed first.
Comment 11 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-15 12:01:08 UTC 
(In reply to Kubilay Kocak from comment #10)

I get it already :)

Indeed, PORTREVISION should be bumped to catch the libxkbcommon update, but it seems that I was the only one who had this problem.

From /var/log/gdm/:0-greeter.log.*

usr/local/lib/libxkbcommon-x11.so.0: version V_0.5.0 required by /usr/local/lib/libmutter.so.0 not defined
Comment 12 Jia-Shiun Li 2016-11-22 04:12:16 UTC 
It affecfs gnome-shell too. libxkbcommon -> mutter -> gnome-shell.

It failed gnome-shell since last week or so but I was too lazy to find out root cause. Until I found the build to recent gnome-shell update failed too.
Comment 13 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-11-22 21:43:35 UTC 
(In reply to jiashiun from comment #12)

Thanks for reporting. 

I'll update mutter patch to add missing dependencies before commit it.
Comment 14 commit-hook freebsd_committer freebsd_triage 2016-12-02 22:01:09 UTC 
A commit references this bug:

Author: cpm
Date: Fri Dec  2 22:01:02 UTC 2016
New revision: 427584
URL: https://svnweb.freebsd.org/changeset/ports/427584

Log:
  x11-wm/mutter: Update to 3.18.4

  - Update mutter to 3.18.4
  - Add LICENSE and LICENSE_FILE
  - Record TIMESTAMP and distinfo checksum (3.18.4)
  - Regenerate patches with make makepatch
  - Add WWW to pkg-descr

  PR:		214289
  Submitted by:	cpm
  Reviewed by:	amdmi3, feld (mentors)
  Approved by:	kwm (GNOME team), amdmi3, feld (mentors)

Changes:
  head/x11-wm/mutter/Makefile
  head/x11-wm/mutter/distinfo
  head/x11-wm/mutter/files/patch-src_Makefile.in
  head/x11-wm/mutter/pkg-descr
Comment 15 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-12-02 22:01:55 UTC 
Committed, thanks!