Bug 219533 - www/libxul: fix shebangs
Summary: www/libxul: fix shebangs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-05-25 14:23 UTC by Carlos J. Puga Medina
Modified: 2017-06-16 10:58 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
patch (865 bytes, patch)
2017-05-25 14:23 UTC, Carlos J. Puga Medina 		jbeich: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-25 14:23:33 UTC 
Created attachment 182885 [details]
patch

- Fix shebangs
- Bump PORTREVISION
Comment 1 John Hein 2017-05-25 15:55:36 UTC 
+1

Without this patch, stage-qa gives:

Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/libxul/sdk/bin/xpidl.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/libxul/sdk/bin/xpt.py'
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-06-15 11:00:47 UTC 
Comment on attachment 182885 [details]
patch

Looks fine but move SHEBANG_FILES just after USES line to match execution order.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-06-16 10:57:56 UTC 
A commit references this bug:

Author: cpm
Date: Fri Jun 16 10:57:15 UTC 2017
New revision: 443684
URL: https://svnweb.freebsd.org/changeset/ports/443684

Log:
  - Fix shebangs
  - Bump PORTREVISION

  Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/libxul/sdk/bin/xpidl.py'
  Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/libxul/sdk/bin/xpt.py'

  PR:		219533
  Submitted by:	cpm
  Approved by:	jbeich (gecko)

Changes:
  head/www/libxul/Makefile
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-06-16 10:58:37 UTC 
Committed!

Thanks