Bug 204545 - Adding quirk entry for some (Acer C720P Chromebook) firmware in keyboard module
Summary: Adding quirk entry for some (Acer C720P Chromebook) firmware in keyboard module
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: easy, feature, needs-patch, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-14 18:39 UTC by pitwuu
Modified: 2019-01-13 21:42 UTC (History)
2 users (show)

See Also:
koobs: mfc-stable10?
koobs: mfc-stable9?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pitwuu 2015-11-14 18:39:39 UTC 
Basically a one-liner to make the keyboard work on my machine (C720p).
Has been tested.

Update the struct in sys/dev/atkbdc/atkbdc.c:124

static struct atkbdc_quirks quirks[] = {
    {"coreboot", "Acer", "Peppy",
	KBDC_QUIRK_KEEP_ACTIVATED | KBDC_QUIRK_IGNORE_PROBE_RESULT |
	KBDC_QUIRK_RESET_AFTER_PROBE | KBDC_QUIRK_SETLEDS_ON_INIT},
    {"coreboot", "Google", "Peppy",
	KBDC_QUIRK_KEEP_ACTIVATED | KBDC_QUIRK_IGNORE_PROBE_RESULT |
	KBDC_QUIRK_RESET_AFTER_PROBE | KBDC_QUIRK_SETLEDS_ON_INIT},

    {NULL, NULL, NULL, 0}
};

Ref:
https://lists.freebsd.org/pipermail/svn-src-head/2015-February/068276.html

-- Philippe Michaud-Boudreault
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-25 06:23:37 UTC 
CC grembo, who committed the original quirks in r278787

[1] https://svnweb.freebsd.org/changeset/base/278787
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-25 06:23:54 UTC 
This would be a good candidate for MFC
Comment 3 Michael Gmelin freebsd_committer freebsd_triage 2015-12-27 02:54:21 UTC 
Looks good to me in general (this is pretty much the idea behind those quirks).

Question: Is your memory detected properly? The Acer 720 required a quirk boot/i386/libi386/biosmem.c.
Comment 4 pitwuu 2015-12-29 05:01:10 UTC 
hi there, yes, the memory works just fine.
Comment 5 Michael Gmelin freebsd_committer freebsd_triage 2015-12-29 12:28:38 UTC 
Could you please add the output of

kenv

and

cat /var/run/dmesg.boot 

to this ticket? (feel free to remove system serial and uuids from the output).

Thanks
Comment 6 pitwuu 2016-11-24 13:15:13 UTC 
Hi, would like to bump it.
This would fix my issue, could it be pulled in? Basically just adding an entry for 'Google' (which Chromebooks are).
Comment 7 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-13 21:42:36 UTC 
Closing as OBE. The base r307468 marked all Chromebooks as the ones that require keyboard workaround, so there is no need for individual models quirks.