Bug 238656 - qlxge: replace device_printf with QL_DPRINT2 in qls_os.c
Summary: qlxge: replace device_printf with QL_DPRINT2 in qls_os.c
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Kevin Bowling
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-06-17 11:25 UTC by Fuqian
Modified: 2024-06-07 05:52 UTC (History)
1 user (show)

See Also:

Attachments
The patch file (3.31 KB, patch)
2019-06-17 11:25 UTC, Fuqian 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fuqian 2019-06-17 11:25:32 UTC 
Created attachment 205174 [details]
The patch file

QL_DPRINT2 checks the debug level first before printing.
Replace device_printf with QL_DPRINT2 to check debug level
first before printing out the kernel pointers.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-28 05:41:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=ae389777583dca0e354fdd43aca3413e209160f4

commit ae389777583dca0e354fdd43aca3413e209160f4
Author:     Fuqian Huang <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:40:12 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-28 05:40:12 +0000

    qlxge: replace device_printf with QL_DPRINT2

    QL_DPRINT2 checks the debug level first before printing.
    Replace device_printf with QL_DPRINT2 to check debug level
    first before printing out the kernel pointers.

    PR:             238656
    MFC after:      1 week

 sys/dev/qlxge/qls_os.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-07 05:50:18 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=265ca6efb443dadd1d1fac3c807d45223c648779

commit 265ca6efb443dadd1d1fac3c807d45223c648779
Author:     Fuqian Huang <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:40:12 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-06-07 05:48:05 +0000

    qlxge: replace device_printf with QL_DPRINT2

    QL_DPRINT2 checks the debug level first before printing.
    Replace device_printf with QL_DPRINT2 to check debug level
    first before printing out the kernel pointers.

    PR:             238656

    (cherry picked from commit ae389777583dca0e354fdd43aca3413e209160f4)

 sys/dev/qlxge/qls_os.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)