Bug 242802 - [snd:hda] fix no sound on headphones of Asus UX331UAL (ALC294)
Summary: [snd:hda] fix no sound on headphones of Asus UX331UAL (ALC294)
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.1-RELEASE
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-12-22 14:20 UTC by Lutz Bichler
Modified: 2024-05-23 00:24 UTC (History)
2 users (show)

See Also:

Attachments
Enable headphone jack on Asus UX331UAL (1.53 KB, patch)
2019-12-22 14:20 UTC, Lutz Bichler 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lutz Bichler 2019-12-22 14:20:36 UTC 
Created attachment 210138 [details]
Enable headphone jack on Asus UX331UAL

I need to apply the attached patch to enable sound on the headphone jack of an Asus UX331UAL.
Comment 1 Christos Margiolis freebsd_committer freebsd_triage 2024-05-20 14:34:08 UTC 
Hello Lutz,

I submitted your patch for review: https://reviews.freebsd.org/D45238

One question: what is the rationale behind using `config` for nid25, instead of `patch_str`?
Comment 2 Lutz Bichler 2024-05-21 16:56:40 UTC 
Hi Christos,

if I remember right, I just did some pattern matching and was happy that it worked :-). It is quite likely that things should be done in a different way. Also, the code of hdaa_patches.c looked a bit different at the time this was done.

Best regards
Lutz
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-22 22:21:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=93ad59a251897431627345c287390ae134925a95

commit 93ad59a251897431627345c287390ae134925a95
Author:     Lutz Bichler <Lutz.Bichler@gmail.com>
AuthorDate: 2024-05-22 22:19:50 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2024-05-22 22:19:50 +0000

    snd_hda: Add patch for Asus UX331UAL

    PR:             242802
    MFC after:      1 day
    Differential Revision:  https://reviews.freebsd.org/D45238

 sys/dev/sound/pci/hda/hdaa_patches.c | 11 +++++++++++
 sys/dev/sound/pci/hda/hdac.h         |  1 +
 2 files changed, 12 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-23 00:24:53 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1fb0a65ab2dd7f6fb5dfcac2d78b6dcb6e3c6c9e

commit 1fb0a65ab2dd7f6fb5dfcac2d78b6dcb6e3c6c9e
Author:     Lutz Bichler <Lutz.Bichler@gmail.com>
AuthorDate: 2024-05-22 22:19:50 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2024-05-23 00:24:15 +0000

    snd_hda: Add patch for Asus UX331UAL

    PR:             242802
    MFC after:      1 day
    Differential Revision:  https://reviews.freebsd.org/D45238

    (cherry picked from commit 93ad59a251897431627345c287390ae134925a95)

 sys/dev/sound/pci/hda/hdaa_patches.c | 11 +++++++++++
 sys/dev/sound/pci/hda/hdac.h         |  1 +
 2 files changed, 12 insertions(+)