Created attachment 229197 [details] Git diff of new port. Add new port py-typish. This is required by math/py-nptyping (#259507), which is in turn required for cad/py-cadquery (#259510). Please note that the CHEESESHOP was not used as it only contains a wheel.
Thanks for the new port Neal! Could you please: - Confirm QA (portlint, poudriere make test for all Python versions) - Ask upstream to produce and upload an sdist (including LICENSE_FILE and test suite) then reference the upstream issue or PR here (See Also) Review items: - Add a comment above USE_GITHUB referencing why !CHEESESHOP and include upstream reference created above. - Add 'python' to CATEGORIES - nptyping>1.3.0 should be >= (per setup.py) - Remove development test dependencies from TEST_DEPENDS if they are not *required* (ie: tests *don't* fail when they're not installed): coverage, codecov, pylint. If tests do fail when not installed, patch them out and/or add "-o addopts=" to pytest invocation in do-test: target, to override/null out additional/unecessary pytest configurations. Openn issue or PR upstream to make these dependencies tests_require += extras_require["dev"], annd not compulsory for downstream testing. - Port declares "USES=python:3.6+" but upstream declares 3.5-3.9. Which is correct, tested for upstream, and pass tests? I also note an upstream issue with test failures for 3.9.
Created attachment 229224 [details] Git diff of new port. This updated patch includes many of the requested changes. I can confirm that I have portlinted and the only failure is the port math/py-nptyping which is a test dependency, but has not yet been committed and in fact depends on this port. Hopefully the potential circular dependency will not be a problem as it's only a test dependency. - Poudriere testport run OK. I have no idea how to run it for non-default versions. - Comment about CHEESESHOP added. - python category added. - nptyping dependency updates. - Unneeded test dependencies removed. I had originally a smaller set, but the setup.py file calls for the set as originally submitted, so for the sake of completeness they were added. The set in this patch is all that is in fact needed. As for asking upstream for an sdist; you may have to expand on that as I have no idea what that is. Please note that this I am submitting this port as a dependency of cad/py-cadquery. As long as that works, that is really all I care about.
I forgot to set the maintainer feedback on my last comment. The user interface of this bug tracker is rather obtuse.
as far as i know, this is the show stopper to unbreak cadquery. the maintainer gave feedback already. would someone pick this up?
(In reply to Neal Nelson from comment #2) --- If you run poudriere bulk some/port@all that has flavors, all flavors will be built. poudriere bulk some/port will build the default flavor. If you need to test a non default flavor, run poudriere testport some/port@flavor --- https://wiki.freebsd.org/Ports/FlavorsAndSubPackages And yes, it is a circular dependency between typish and nptyping and that's cool because I never see this happened. Don't see a big problem commit separately these ports.
(In reply to Neal Nelson from comment #0) Whats the meaning of expression "Please note that the CHEESESHOP was not used as it only contains a wheel." Thanks
Open question from eduardo@ remains.por