Bug 261586 - databases/py-mysql-connector-python: Fix incorrect security/py-gssapi RUN_DEPENDS version specifier
Summary: databases/py-mysql-connector-python: Fix incorrect security/py-gssapi RUN_DEP...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2022-01-31 01:42 UTC by geraud
Modified: 2022-02-01 18:49 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bofh)
koobs: merge-quarterly-


Attachments
Patch Makefile (671 bytes, text/plain)
2022-01-31 01:42 UTC, geraud
koobs: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description geraud 2022-01-31 01:42:17 UTC
Created attachment 231454 [details]
Patch Makefile

In case of GSSAPI option enabled, Makefile requires the py-gssapi version to be greater than 1.6.14 which is the current version we're having in ports.

Adjust version dependency to the one matching the source (gssapi>=1.6.9) to allow the build.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-31 01:52:49 UTC
@Reporter Could you please:

- Confirm, that the pstream sources (setup.py or otherwise, please mention where) specify 'gssapi>=1.6.9', and the version spec does not include a max version pin (>x,<y) ?

- Clarify what the current failure mode is, if any, including steps to reproduce
Comment 2 geraud 2022-01-31 02:34:53 UTC
(In reply to Kubilay Kocak from comment #1)

1) Here's the line of setup.py@v8.0.28

        "gssapi": ["gssapi>=1.6.9"],

Reference : https://github.com/mysql/mysql-connector-python/blob/8.0.28/setup.py#L146

2) I tried to build py-mysql-connector-python this morning through poudriere (as a dependency of netbox I believe), and here is the error I got (cut to the relevant part) :

[...]
===>   py38-mysql-connector-python-8.0.28 depends on package: py38-gssapi>1.6.14 - not found
===>   Installing existing package /packages/All/py38-gssapi-1.6.14.pkg
[poudriere.vm.skazy.name] Installing py38-gssapi-1.6.14...
[poudriere.vm.skazy.name] `-- Installing krb5-1.19.2...
[poudriere.vm.skazy.name] `-- Extracting krb5-1.19.2: .......... done
[poudriere.vm.skazy.name] `-- Installing py38-decorator-5.1.1...
[poudriere.vm.skazy.name] `-- Extracting py38-decorator-5.1.1: .......... done
[poudriere.vm.skazy.name] Extracting py38-gssapi-1.6.14: .......... done
===>   py38-mysql-connector-python-8.0.28 depends on package: py38-gssapi>1.6.14 - not found
*** Error code 1
[...]
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-31 03:46:08 UTC
(In reply to geraud from comment #2)

Thank you for the detail Geraud.

So to clarify (I missed the interpretation from comment 0 referencing "greater than"), the the bug, other than the version spec not matching upstream, is a missing = in `gssapi>1.6.14` requiring a higher (currently non-existent) version.

Attachment 231454 [details] correctly resolves both issues.

Quarterly [1] is not affected.

[1] https://cgit.freebsd.org/ports/tree/databases/py-mysql-connector-python/Makefile?h=2022Q1
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-31 03:46:44 UTC
Comment on attachment 231454 [details]
Patch Makefile

Approved by: portmgr (bugfix: dependencies)
MFH: No (not affected)
Comment 5 geraud 2022-01-31 05:30:59 UTC
(In reply to Kubilay Kocak from comment #3)

@koobs

Ah, my apologies. After reading my initial comment, I only realize that my wording was less than ideal. I'll try to be more precise in the future.

Thank you for the approval.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-02-01 18:49:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2b7ade4f96096fcfe1edfa5672d691377918c3dc

commit 2b7ade4f96096fcfe1edfa5672d691377918c3dc
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2022-02-01 18:46:44 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2022-02-01 18:46:44 +0000

    databases/py-mysql-connector-python: Fix incorrect RUN_DEPENDS version

    PR:             261586
    Reported by:    geraud@gcu.info

 databases/py-mysql-connector-python/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)